Atomic Load and Store operations for Triton (tl.atomic_store/tl.atomic_load) #5187
+435
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plotfi
commented
Nov 19, 2024
| @@ -1730,6 +1730,66 @@ def load(pointer, mask=None, other=None, boundary_check=(), padding_option="", c | |||
| volatile, _builder) | |||
|
|
|||
|
|
|||
| @builtin | |||
| def atomic_load(pointer, mask=None, other=None, sem="", scope="", boundary_check=(), padding_option="", | |||
| cache_modifier="", eviction_policy="", volatile=False, _builder=None): | |||
There was a problem hiding this comment.
Comment needs updating for sem/scope.
plotfi
commented
Nov 19, 2024
| @builtin | ||
| def atomic_store(pointer, value, mask=None, sem="", scope="", boundary_check=(), cache_modifier="", eviction_policy="", | ||
| _builder=None): | ||
| """ |
There was a problem hiding this comment.
Comment needs updating for sem/scope.
|
@peterbell10 is familiar with this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following PR adds tl.atomic_load and tl.atomic_store.
This allows for memory semantics that acquire and release in a total ordering for a given scope (cta/gpu/system).
TODO: Will add larger description once I take this PR out of draft mode.
I am not making a trivial change, such as fixing a typo in a comment.
I have written a PR description following these
rules.
I have run
pre-commit run --from-ref origin/main --to-ref HEAD.Select one of the following.
I have added tests.
/testforlittests/unittestfor C++ tests/python/testfor end-to-end testsThe
littests I have added follow these best practices,including the "tests should be minimal" section. (Usually running Python code
and using the instructions it generates is not minimal.)