-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Format #111
Format #111
Conversation
I think formatting is a good idea. I wouldn't format the wrapped file, since it is auto-generated, which makes it hard to compare it against changes once we have to re-generate it for some reason. |
I think so, too. We could in principle format the file at the end of the generator, but I would still advocate for not formatting the wrapped file. |
Again and again, we have a segfault when building the docs in CI. Do you know why? |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #111 +/- ##
==========================================
+ Coverage 17.64% 17.80% +0.16%
==========================================
Files 3 3
Lines 1423 1427 +4
==========================================
+ Hits 251 254 +3
- Misses 1172 1173 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with what you have said above - good idea 👍
No idea, sorry. Looks like this has been happening for quite some time already... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I didn't check every line in the modified files but I think it should be fine
Are you fine with merging, @sloede? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only did a quick scan of the changes to test/
, but nothing overly atrocious has caught my attention. LGTM, thanks!
Maybe it's a good idea to also format P4est.jl. I excluded the wrapped file for now. I think most of it looks acceptable. What do you think, @sloede, @ranocha?