Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Joshua Lampert <[email protected]>
  • Loading branch information
DanielDoehring and JoshuaLampert authored Jan 9, 2025
1 parent 411f657 commit 22b9a50
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 10 deletions.
8 changes: 0 additions & 8 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,6 @@ Trixi.jl follows the interpretation of [semantic versioning (semver)](https://ju
used in the Julia ecosystem. Notable changes will be documented in this file
for human readability.

## Changes when updating to v0.10 from v0.9.x

#### Changed

- The `PairedExplicitRK2` constructor with second argument `base_path_monomial_coeffs::AbstractString` requires
now `dt_opt`, `bS`, `cS` to be given as keyword arguments ([#2184]).
Previously, those where standard function parameters, in the same order as listed above.

## Changes in the v0.9 lifecycle

#### Added
Expand Down
2 changes: 1 addition & 1 deletion examples/structured_2d_dgsem/elixir_euler_vortex_perk4.jl
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ ode_algorithm = Trixi.PairedExplicitRK4(num_stages, path_coeff_file)
# run the simulation

sol = Trixi.solve(ode, ode_algorithm,
dt = 42.0, # Not used
dt = 42.0, # solve needs some value here but it will be overwritten by the stepsize_callback
save_everystep = false, callback = callbacks);

summary_callback()
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ end
In this case the optimal CFL number cannot be computed and the [`StepsizeCallback`](@ref) cannot be used.
- `tspan`: Time span of the simulation.
- `semi` (`AbstractSemidiscretization`): Semidiscretization setup.
- `eig_vals` (`Vector{ComplexF64}`): Eigenvalues of the Jacobian of the right-hand side (rhs) of the ODEProblem after the
- `eig_vals` (`Vector{ComplexF64}`): Eigenvalues of the Jacobian of the right-hand side (rhs) of the `ODEProblem` after the
equation has been semidiscretized.
- `cS3` (`Float64`, optional): Value of $c_{S-3}$ in the Butcher tableau, where
$S$ is the number of stages. Default is `1.0f0`.
Expand Down

0 comments on commit 22b9a50

Please sign in to comment.