Add comments

trixi-framework · Oct 18, 2023 · 3079153 · 3079153
1 parent 2297486
commit 3079153
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/solvers/dgsem_tree/container_viscous_2d.jl b/src/solvers/dgsem_tree/container_viscous_2d.jl
@@ -1,7 +1,10 @@
 mutable struct ViscousContainer2D{uEltype <: Real}
     u_transformed::Array{uEltype, 4}
     # Using an outer fixed-size datastructure leads to nasty implementations,
-    # avoid this here.
+    # see https://github.com/trixi-framework/Trixi.jl/pull/1629#discussion_r1355293953.
+    # Also: This does not result in speed up compared to using tuples for the internal 
+    # datastructures, see 
+    # https://github.com/trixi-framework/Trixi.jl/pull/1629#discussion_r1363352188.
     gradients::Vector{Array{uEltype, 4}}
     flux_viscous::Vector{Array{uEltype, 4}}
 

diff --git a/src/solvers/dgsem_tree/container_viscous_3d.jl b/src/solvers/dgsem_tree/container_viscous_3d.jl
@@ -1,7 +1,10 @@
 mutable struct ViscousContainer3D{uEltype <: Real}
     u_transformed::Array{uEltype, 5}
     # Using an outer fixed-size datastructure leads to nasty implementations,
-    # avoid this here.
+    # see https://github.com/trixi-framework/Trixi.jl/pull/1629#discussion_r1355293953.
+    # Also: This does not result in speed up compared to using tuples for the internal 
+    # datastructures, see 
+    # https://github.com/trixi-framework/Trixi.jl/pull/1629#discussion_r1363352188.
     gradients::Vector{Array{uEltype, 5}}
     flux_viscous::Vector{Array{uEltype, 5}}