Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Advection diffusion elixirs with Erikkson-Johnson initial condition #1543

Closed
jlchan opened this issue Jun 20, 2023 · 1 comment
Closed

Advection diffusion elixirs with Erikkson-Johnson initial condition #1543

jlchan opened this issue Jun 20, 2023 · 1 comment
Labels
good first issue Good for newcomers

Comments

@jlchan
Copy link
Contributor

jlchan commented Jun 20, 2023 

          Should this maybe throw an exception if a user sets the `diffusivity()` too large?

Originally posted by @andrewwinters5000 in #1493 (comment)
@jlchan jlchan mentioned this issue Jun 20, 2023
Merged
@jlchan jlchan added the good first issue Good for newcomers label Jun 20, 2023
@jlchan
Copy link
Contributor Author

jlchan commented Dec 13, 2023

I'd like to close this since, as pointed out in #1493 (comment), the sqrt will catch this issue.

@jlchan jlchan closed this as completed Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jlchan