Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parabolic BCs for P4estMesh{2} #1493

Merged
merged 68 commits into from
Jun 23, 2023

Conversation

jlchan
Copy link
Contributor

@jlchan jlchan commented May 26, 2023

This PR adds parabolic boundary conditions for P4estMesh{2}. We added tests for non-periodic advection-diffusion on curved P4est meshes and the lid-driven cavity problem.

@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #1493 (28be493) into main (1b69182) will increase coverage by 0.06%.
The diff coverage is 97.81%.

@@            Coverage Diff             @@
##             main    #1493      +/-   ##
==========================================
+ Coverage   95.99%   96.04%   +0.06%     
==========================================
  Files         365      368       +3     
  Lines       30914    31049     +135     
==========================================
+ Hits        29673    29821     +148     
+ Misses       1241     1228      -13     
Flag Coverage Δ
unittests 96.04% <97.81%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/solvers/dgsem_p4est/dg_2d_parabolic.jl 95.74% <94.00%> (+6.69%) ⬆️
...m/elixir_advection_diffusion_nonperiodic_curved.jl 100.00% <100.00%> (ø)
.../p4est_2d_dgsem/elixir_navierstokes_convergence.jl 100.00% <100.00%> (ø)
..._2d_dgsem/elixir_navierstokes_lid_driven_cavity.jl 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@jlchan
Copy link
Contributor Author

jlchan commented Jun 15, 2023

Bumping - @andrewwinters5000 would you have time for a quick review? @ranocha has gone over this PR once already.

test/test_parabolic_2d.jl Outdated Show resolved Hide resolved
ranocha
ranocha previously approved these changes Jun 19, 2023
Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me so far but I would like to get another review of @andrewwinters5000 (or someone else loving to look at curved code)

@jlchan jlchan requested a review from ranocha June 19, 2023 19:06
Copy link
Member

@andrewwinters5000 andrewwinters5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be ambiguity of how flipped orientation interfaces are handled (although I only had a brief look at the implementation).

Copy link
Member

@andrewwinters5000 andrewwinters5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/solvers/dgsem_p4est/dg_2d_parabolic.jl Show resolved Hide resolved
@ranocha ranocha enabled auto-merge (squash) June 22, 2023 15:43
@jlchan
Copy link
Contributor Author

jlchan commented Jun 22, 2023

CI failures are unrelated and due to Plots.jl (see also #1548 and jheinen/GR.jl#522)

@ranocha ranocha merged commit b7be585 into trixi-framework:main Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants