-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parabolic BCs for P4estMesh{2}
#1493
Conversation
Co-authored-by: Hendrik Ranocha <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1493 +/- ##
==========================================
+ Coverage 95.99% 96.04% +0.06%
==========================================
Files 365 368 +3
Lines 30914 31049 +135
==========================================
+ Hits 29673 29821 +148
+ Misses 1241 1228 -13
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Bumping - @andrewwinters5000 would you have time for a quick review? @ranocha has gone over this PR once already. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me so far but I would like to get another review of @andrewwinters5000 (or someone else loving to look at curved code)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be ambiguity of how flipped orientation interfaces are handled (although I only had a brief look at the implementation).
examples/p4est_2d_dgsem/elixir_advection_diffusion_nonperiodic_curved.jl
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
CI failures are unrelated and due to Plots.jl (see also #1548 and jheinen/GR.jl#522) |
This PR adds parabolic boundary conditions for P4estMesh{2}. We added tests for non-periodic advection-diffusion on curved
P4est
meshes and the lid-driven cavity problem.