Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for hyperbolic-parabolic systems to TreeMesh2D #1156

Merged
merged 161 commits into from
Aug 9, 2022
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
161 commits
Select commit Hold shift + click to select a range
1f42e4f
Add prototype for advection-diffusion elixir for TreeMesh2D
sloede Jun 2, 2022
d5fba2a
Merge branch 'dev' into parabolic-treemesh
sloede Jun 2, 2022
586f8e1
Merge branch 'dev' into parabolic-treemesh
sloede Jun 3, 2022
2cc327b
Initial implementation of `calc_gradient!` for TreeMesh{2}
sloede Jun 3, 2022
ed13d72
First complete implementation of the parabolic rhs operator for TreeMesh
sloede Jun 3, 2022
f83374e
Make it work
sloede Jun 3, 2022
12c59eb
Add first elixir that works
sloede Jun 3, 2022
03a1a60
Clean up elixir
sloede Jun 3, 2022
60cce54
first draft of container for Navier-Stokes constants and fluxes
andrewwinters5000 Jun 7, 2022
46ae5fb
remove unneeded temperature computation
andrewwinters5000 Jun 7, 2022
4f6558f
draft of elixir with possible boundary condition structure
andrewwinters5000 Jun 7, 2022
dde54d3
added manufactured solution and source term
andrewwinters5000 Jun 7, 2022
daaeac3
fix typo in function name for MMS
andrewwinters5000 Jun 7, 2022
4a39883
update variable names for consistency. improve comments
andrewwinters5000 Jun 8, 2022
84d8454
Merge branch 'main' into nav_stokes_2d
andrewwinters5000 Jun 8, 2022
3879a3f
fix dumb typos in new equation system name
andrewwinters5000 Jun 8, 2022
435e081
actually export new equations
andrewwinters5000 Jun 8, 2022
7b59fef
add comment near variable_mapping declaration.
andrewwinters5000 Jun 8, 2022
b33570f
Merge branch 'dev' into parabolic-treemesh
ranocha Jun 8, 2022
d3b7870
Merge branch 'parabolic-treemesh' into nav_stokes_2d
ranocha Jun 8, 2022
5dc8301
Apply suggestions from code review
andrewwinters5000 Jun 9, 2022
f316684
parabolic equations now exported separately
andrewwinters5000 Jun 9, 2022
02c14e1
change name to CompressibleNavierStokesEquations2D
andrewwinters5000 Jun 9, 2022
dd733bb
export NS with proper name
andrewwinters5000 Jun 9, 2022
a1a48fe
explicitly require compressible Euler in the type parameter
andrewwinters5000 Jun 10, 2022
d8db203
name kinematic viscosity nu for consistency with Lattice-Boltzmann
andrewwinters5000 Jun 10, 2022
06e69b8
add promotion in constructor
andrewwinters5000 Jun 10, 2022
eda9737
make Reynolds, Prandtl, Mach, and kappa keyword arguments
andrewwinters5000 Jun 10, 2022
b469bce
update constructor call in elixir
andrewwinters5000 Jun 10, 2022
fb646b0
reduce computation by exploiting stress tensor symmetry
andrewwinters5000 Jun 10, 2022
f32ef8c
Merge remote-tracking branch 'origin/main' into nav_stokes_2d
jlchan Jun 14, 2022
f6bca76
fix unpacking of flux
jlchan Jun 14, 2022
9b5dd35
modifying parabolic cache creation
jlchan Jun 14, 2022
21e1c99
comments
jlchan Jun 15, 2022
19f004e
comments
jlchan Jun 15, 2022
de442bf
formatting and renaming equations to equations_hyperbolic
jlchan Jun 15, 2022
298b726
fix unpacking of gradients in flux
jlchan Jun 15, 2022
01f8325
adding CNS BCs
jlchan Jun 15, 2022
3f04e71
adding lid-driven cavity elixir
jlchan Jun 15, 2022
36e3b68
adding variable transform, editing cons2prim for CNS
jlchan Jun 15, 2022
6bf91eb
add prim2cons for NS (inconsistent right now)
jlchan Jun 15, 2022
a0ea3f0
add draft of DGMulti Navier Stokes convergence elixir
jlchan Jun 15, 2022
c103e2e
converging solution using elixir for TreeMesh with BCs
jlchan Jun 27, 2022
845c133
Merge branch 'main' into nav_stokes_2d
jlchan Jun 27, 2022
3d717a6
fixing DGMulti advection diffusion elixir convergence
jlchan Jun 27, 2022
8471273
naming equations as parabolic/hyperbolic
jlchan Jun 27, 2022
96667e6
generalizing transform_variables
jlchan Jun 27, 2022
73e4740
add TODO
jlchan Jun 27, 2022
2c05f66
additional checks on get_unsigned_normal
jlchan Jun 27, 2022
d5e7f9e
adding isothermal BC
jlchan Jun 27, 2022
89acae8
commenting out unused CNS functions for now
jlchan Jun 27, 2022
f503b85
fix call to transform_variables
jlchan Jun 27, 2022
41b41a9
comments and cleanup
jlchan Jun 27, 2022
1107def
changing default solver and Re for cavity
jlchan Jun 27, 2022
f90afb9
adding more advection diffusion tests
jlchan Jun 27, 2022
2e7019f
label tests
jlchan Jun 28, 2022
063b602
add gradient_variables field to SemidiscretizationHyperbolicParabolic
jlchan Jun 28, 2022
50d76df
Revert "add gradient_variables field to SemidiscretizationHyperbolicP…
jlchan Jun 28, 2022
5b112e9
Merge branch 'main' into nav_stokes_2d
jlchan Jul 11, 2022
549793c
allowing for specialization in transform_variables
jlchan Jul 12, 2022
3e3e41f
formatting and comments
jlchan Jul 13, 2022
6347151
reverting elixir
jlchan Jul 13, 2022
eb98568
comments
jlchan Jul 13, 2022
766cdc5
standardizing time tol
jlchan Jul 13, 2022
c865fb7
minor fix to CNS boundary flux for convenience
jlchan Jul 13, 2022
08768a7
formatting + comments
jlchan Jul 13, 2022
6c38bdb
using primitive variables in viscous flux instead of conservative
jlchan Jul 13, 2022
0f67dd0
minor formatting
jlchan Jul 13, 2022
6a1d908
add CNS tests
jlchan Jul 13, 2022
6d5be6c
fix test
jlchan Jul 13, 2022
bc58754
testing if scoping issues fix TreeMesh tests
jlchan Jul 13, 2022
f13045a
decreasing timestep tol for TreeMesh parabolic test
jlchan Jul 13, 2022
d29d583
enabling periodic BCs for TreeMesh + more tests
jlchan Jul 13, 2022
abd020b
fix density BC flux (unused, but could be useful)
jlchan Jul 13, 2022
663f465
adding non-working TreeMesh elixirs
jlchan Jul 15, 2022
5ae580b
adding AD checks
jlchan Jul 15, 2022
e0c3b84
Merge remote-tracking branch 'origin/main' into nav_stokes_2d
jlchan Jul 28, 2022
bfffc00
standardizing parameters in convergence elixirs
jlchan Jul 28, 2022
17eafbb
minor cleanup
jlchan Jul 28, 2022
0c4e098
revert DGMulti CNS elixir setup back to the one used in tests
jlchan Jul 28, 2022
b70bbc0
adding TreeMesh CNS convergence test
jlchan Jul 28, 2022
13e0c8f
removing redundant elixir
jlchan Jul 28, 2022
8cecb5f
add more tests
jlchan Jul 28, 2022
adb8eca
add more test
jlchan Jul 28, 2022
3281b49
Apply suggestions from code review
andrewwinters5000 Jul 29, 2022
d643679
set version to v0.4.43
ranocha Jul 29, 2022
a6244c2
set development version to v0.4.44-pre
ranocha Jul 29, 2022
d6ab952
add YouTube links to JuliaCon presentations (#1192)
ranocha Jul 29, 2022
689fe59
improved readability of equation docstrings in compressible Euler files
andrewwinters5000 Jul 29, 2022
e8a24a7
Merge branch 'dev' into parabolic-treemesh
ranocha Jul 29, 2022
6002ba6
Navier-Stokes in 2D on DGMulti and TreeMesh (#1165)
andrewwinters5000 Jul 29, 2022
24f2d82
Merge branch 'nav_stokes_2d' into parabolic-treemesh
andrewwinters5000 Jul 29, 2022
5f48588
add docstring for CNS equations
andrewwinters5000 Jul 29, 2022
baea3ec
removing some addressed TODOs
jlchan Jul 29, 2022
8b0e5d3
Merge branch 'parabolic-treemesh' of github.com:trixi-framework/Trixi…
andrewwinters5000 Jul 29, 2022
0b17ec6
adjust definition of the kappa constant
andrewwinters5000 Jul 29, 2022
ba49eef
avoid overwriting u_grad with viscous_flux results
jlchan Jul 29, 2022
a8897aa
remove old TODOs
jlchan Jul 29, 2022
e0fddfa
clarify TODOs for later
jlchan Jul 29, 2022
baec967
removing let statements
jlchan Jul 29, 2022
f6fd1f8
rearrange main docstring. Fix typos in math environment causing it to…
andrewwinters5000 Aug 3, 2022
7a4106f
Merge branch 'dev' into parabolic-treemesh
ranocha Aug 8, 2022
0b63e58
update TODO notes
ranocha Aug 8, 2022
8bd0e1d
Apply suggestions from code review
ranocha Aug 8, 2022
dcdbe07
update TODO notes
ranocha Aug 8, 2022
5eae2b0
Apply suggestions from code review
ranocha Aug 8, 2022
8177678
update TODO notes
ranocha Aug 8, 2022
ada3fb9
changing diffusivity names
jlchan Aug 8, 2022
c547b1c
Reynolds/Prandtl number name changes for consistency
jlchan Aug 8, 2022
d0848b5
Apply suggestions from code review
jlchan Aug 8, 2022
b2f0621
fixing bug introduced by GH code review
jlchan Aug 8, 2022
e3fdde8
moving manufactured solution into the CNS equations file
jlchan Aug 8, 2022
a8ed40e
fix allocation issue
jlchan Aug 8, 2022
9bf3726
get_diffusivity -> diffusivity
ranocha Aug 8, 2022
a6b6d91
removing cruft code, adding comment on messy prim2cons routine
jlchan Aug 8, 2022
ff77812
Merge remote-tracking branch 'origin/parabolic-treemesh' into parabol…
jlchan Aug 8, 2022
69880c4
moving manufactured solution back into elixirs
jlchan Aug 8, 2022
133be3e
Update examples/dgmulti_2d/elixir_advection_diffusion_nonperiodic.jl
jlchan Aug 8, 2022
928347b
TODO -> Todo, and .6 -> 0.6
jlchan Aug 8, 2022
1060898
Update src/solvers/dgsem_tree/dg_2d_parabolic.jl
jlchan Aug 8, 2022
0d358de
adding note to Adiabatic/Isothermal BCs
jlchan Aug 8, 2022
4f757d3
replacing CompressibleNavierStokesEquations with ...Diffusion
jlchan Aug 8, 2022
7382a28
Merge remote-tracking branch 'origin/parabolic-treemesh' into parabol…
jlchan Aug 8, 2022
65f491b
Update src/solvers/dgsem_tree/dg_2d_parabolic.jl
jlchan Aug 8, 2022
d2facb0
Update src/solvers/dgsem_tree/dg_2d_parabolic.jl
jlchan Aug 8, 2022
299f04e
documenting Jacobian sign flip
jlchan Aug 8, 2022
d4843bf
Merge remote-tracking branch 'origin/parabolic-treemesh' into parabol…
jlchan Aug 8, 2022
9ff5f4c
viscous_flux -> flux_viscous
jlchan Aug 8, 2022
144fc59
remove extra arg to `gradient_variable_transformation`
jlchan Aug 8, 2022
ce7a045
Update src/solvers/dgsem_tree/dg_2d_parabolic.jl
jlchan Aug 8, 2022
5bf23e5
change warning to error
jlchan Aug 8, 2022
9f4a8b1
fix bug introduced by search/replace
jlchan Aug 8, 2022
1159377
dg_parabolic -> parabolic_scheme
jlchan Aug 8, 2022
bf42a66
BoundaryConditionViscousWall -> BoundaryConditionNavierStokesWall
jlchan Aug 8, 2022
020fb15
u_grad -> gradients
jlchan Aug 8, 2022
76a8563
fix test
jlchan Aug 8, 2022
0fc9828
renaming
jlchan Aug 8, 2022
3b46afd
update comment
jlchan Aug 8, 2022
8e94965
converting to signature `flux(u, gradients, orientation, equations)`
jlchan Aug 8, 2022
f5f48fc
using prolong2interfaces/boundaries
jlchan Aug 8, 2022
da319b9
unpacking `gradients` and `flux_viscous`
jlchan Aug 8, 2022
4b9b04f
using calc_surface_integral!
jlchan Aug 9, 2022
7b74f19
adding @muladd
jlchan Aug 9, 2022
9b05185
Apply suggestions from code review
ranocha Aug 9, 2022
1ff6b87
update comments
jlchan Aug 9, 2022
5caf63c
Merge remote-tracking branch 'origin/parabolic-treemesh' into parabol…
jlchan Aug 9, 2022
e8bccba
Rename grad_u -> gradients
sloede Aug 9, 2022
f05bc7d
Update src/equations/compressible_navier_stokes_2d.jl
jlchan Aug 9, 2022
5692189
Rename remaining grad_u/u_grad -> gradients
sloede Aug 9, 2022
5437f7b
Refactor into prolong2interfaces!
sloede Aug 9, 2022
be8a5e0
Refactor calc_volume_integral!
sloede Aug 9, 2022
cbadcb8
Refactor calc_interface_flux
sloede Aug 9, 2022
3400e83
Refactor prolong2boundaries!
sloede Aug 9, 2022
cb82c8f
Refactor calc_divergence!
sloede Aug 9, 2022
5c7becc
Formatting consistency
sloede Aug 9, 2022
9510dc8
Remove dispatch on volume integral type
sloede Aug 9, 2022
831f878
Add comment on why surface_integral is passed to prolong2interfaces!
sloede Aug 9, 2022
23015ea
Explicitly use weak form volume integral to allow easy overriding in …
sloede Aug 9, 2022
d1ea1be
Add flux differencing test for CNS test
sloede Aug 9, 2022
9976085
Remove erroneous P4estMesh{2} dispatch
sloede Aug 9, 2022
b06f927
Remove non-cons terms from parabolic solver
sloede Aug 9, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/solvers/dgsem_tree/dg_2d.jl
Original file line number Diff line number Diff line change
Expand Up @@ -961,6 +961,7 @@ end
end


# we pass in the hyperbolic `dg.surface_integral` as a dummy argument for dispatch
function calc_surface_integral!(du, u, mesh::Union{TreeMesh{2}, StructuredMesh{2}},
equations, surface_integral::SurfaceIntegralWeakForm,
dg::DG, cache)
Expand Down
Loading