-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navier-Stokes in 2D on DGMulti and TreeMesh #1165
Merged
Merged
Changes from 1 commit
Commits
Show all changes
78 commits
Select commit
Hold shift + click to select a range
60cce54
first draft of container for Navier-Stokes constants and fluxes
andrewwinters5000 46ae5fb
remove unneeded temperature computation
andrewwinters5000 4f6558f
draft of elixir with possible boundary condition structure
andrewwinters5000 dde54d3
added manufactured solution and source term
andrewwinters5000 daaeac3
fix typo in function name for MMS
andrewwinters5000 4a39883
update variable names for consistency. improve comments
andrewwinters5000 84d8454
Merge branch 'main' into nav_stokes_2d
andrewwinters5000 3879a3f
fix dumb typos in new equation system name
andrewwinters5000 435e081
actually export new equations
andrewwinters5000 7b59fef
add comment near variable_mapping declaration.
andrewwinters5000 d3b7870
Merge branch 'parabolic-treemesh' into nav_stokes_2d
ranocha 5dc8301
Apply suggestions from code review
andrewwinters5000 f316684
parabolic equations now exported separately
andrewwinters5000 02c14e1
change name to CompressibleNavierStokesEquations2D
andrewwinters5000 dd733bb
export NS with proper name
andrewwinters5000 a1a48fe
explicitly require compressible Euler in the type parameter
andrewwinters5000 d8db203
name kinematic viscosity nu for consistency with Lattice-Boltzmann
andrewwinters5000 06e69b8
add promotion in constructor
andrewwinters5000 eda9737
make Reynolds, Prandtl, Mach, and kappa keyword arguments
andrewwinters5000 b469bce
update constructor call in elixir
andrewwinters5000 fb646b0
reduce computation by exploiting stress tensor symmetry
andrewwinters5000 f32ef8c
Merge remote-tracking branch 'origin/main' into nav_stokes_2d
jlchan f6bca76
fix unpacking of flux
jlchan 9b5dd35
modifying parabolic cache creation
jlchan 21e1c99
comments
jlchan 19f004e
comments
jlchan de442bf
formatting and renaming equations to equations_hyperbolic
jlchan 298b726
fix unpacking of gradients in flux
jlchan 01f8325
adding CNS BCs
jlchan 3f04e71
adding lid-driven cavity elixir
jlchan 36e3b68
adding variable transform, editing cons2prim for CNS
jlchan 6bf91eb
add prim2cons for NS (inconsistent right now)
jlchan a0ea3f0
add draft of DGMulti Navier Stokes convergence elixir
jlchan c103e2e
converging solution using elixir for TreeMesh with BCs
jlchan 845c133
Merge branch 'main' into nav_stokes_2d
jlchan 3d717a6
fixing DGMulti advection diffusion elixir convergence
jlchan 8471273
naming equations as parabolic/hyperbolic
jlchan 96667e6
generalizing transform_variables
jlchan 73e4740
add TODO
jlchan 2c05f66
additional checks on get_unsigned_normal
jlchan d5e7f9e
adding isothermal BC
jlchan 89acae8
commenting out unused CNS functions for now
jlchan f503b85
fix call to transform_variables
jlchan 41b41a9
comments and cleanup
jlchan 1107def
changing default solver and Re for cavity
jlchan f90afb9
adding more advection diffusion tests
jlchan 2e7019f
label tests
jlchan 063b602
add gradient_variables field to SemidiscretizationHyperbolicParabolic
jlchan 50d76df
Revert "add gradient_variables field to SemidiscretizationHyperbolicP…
jlchan 5b112e9
Merge branch 'main' into nav_stokes_2d
jlchan 549793c
allowing for specialization in transform_variables
jlchan 3e3e41f
formatting and comments
jlchan 6347151
reverting elixir
jlchan eb98568
comments
jlchan 766cdc5
standardizing time tol
jlchan c865fb7
minor fix to CNS boundary flux for convenience
jlchan 08768a7
formatting + comments
jlchan 6c38bdb
using primitive variables in viscous flux instead of conservative
jlchan 0f67dd0
minor formatting
jlchan 6a1d908
add CNS tests
jlchan 6d5be6c
fix test
jlchan bc58754
testing if scoping issues fix TreeMesh tests
jlchan f13045a
decreasing timestep tol for TreeMesh parabolic test
jlchan d29d583
enabling periodic BCs for TreeMesh + more tests
jlchan abd020b
fix density BC flux (unused, but could be useful)
jlchan 663f465
adding non-working TreeMesh elixirs
jlchan 5ae580b
adding AD checks
jlchan e0c3b84
Merge remote-tracking branch 'origin/main' into nav_stokes_2d
jlchan bfffc00
standardizing parameters in convergence elixirs
jlchan 17eafbb
minor cleanup
jlchan 0c4e098
revert DGMulti CNS elixir setup back to the one used in tests
jlchan b70bbc0
adding TreeMesh CNS convergence test
jlchan 13e0c8f
removing redundant elixir
jlchan 8cecb5f
add more tests
jlchan adb8eca
add more test
jlchan 3281b49
Apply suggestions from code review
andrewwinters5000 98ea1bd
add docstrings
jlchan bf43508
Merge remote-tracking branch 'origin/parabolic-treemesh' into nav_sto…
ranocha File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
explicitly require compressible Euler in the type parameter
- Loading branch information
commit a1a48fe2b0627c55c2d7487997e540c7283639d3
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍