Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a tutorial on adding new parabolic terms #1209
Adding a tutorial on adding new parabolic terms #1209
Changes from 6 commits
ba4702a
362de9c
8807e2a
e3b9b45
10d84fd
82f5e6b
3f034db
f03e6ea
860cf66
2089716
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If users copy this directly to their code, they will run into type instabilities with non-constant globals. What about adding
const
qualifiers tou_left
andu_bottom
or copying their values directly into the corresponding lines?It doesn't really matter for this demonstration of the behavior, but it would probably be nice to follow best practices in the tutorials in general (when it's not too complex).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done - removed
u_left
,u_bottom
.Is the type instability due to the use of
u_left
in the anonymous function?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes - it picks up a global variable from there and the global variable is neither typed nor
const