Upwind FDSBP cleanup, part 2 #1285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Michael Schlottke-Lakemper <[email protected]>
ranocha
force-pushed
the
hr/dev_cleanup
branch
from
628107b to
2ce4cad
Compare
4 tasks
ranocha
added a commit
that referenced
this pull request
Dec 2, 2022
* implementation of positive/negative part preferred by Michael Co-authored-by: Michael Schlottke-Lakemper <[email protected]> * more experimental warnings * let Julia handle promotion of numbers * improve docstring of FluxUpwind * FDSBP constructor * use D_upw as canonical name in examples Co-authored-by: Michael Schlottke-Lakemper <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on the comments of @sloede in #1275.
CC @andrewwinters5000