-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
breaking changes for Trixi.jl v0.5 #1302
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ranocha thanks for organizing this.
For DGMulti
, it would be nice to make the DGMultiMesh
constructors consistent so that dg
is the first argument. This would be a breaking change. If there is some time before v0.5, I can take care of that sometime next week.
That sounds good to me - it would be great if you could introduce the corresponding deprecations next week 👍 |
…of comments and docstrings
the parameter was being initialized as an instance rather than a type
fix deprecation syntax
1270534
to
28a620f
Compare
Thanks!
No, I think its okay. Was it documented, e.g., via a docstring? If so, it would be great if you could mention it in NEWS.md. |
No docstring. I'll add it to the news file soon |
Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small comments, otherwise this LGTM!
Co-authored-by: Michael Schlottke-Lakemper <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
This includes a first set of breaking changes for Trixi.jl v0.5 described in #938.
@jlchan Could you please check that I removed only the
DGMulti
code that you intended to be removed?I will leave this in draft mode until we are ready for the breaking release of Trixi.jl. We also need to update the compat bounds of Trixi.jl at Trixi2Vtk.jl to create our documentation here.