Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add funding agency logos and update acknowledgements #1391

Merged
merged 11 commits into from
Apr 13, 2023
Merged

Conversation

sloede
Copy link
Member

@sloede sloede commented Apr 12, 2023

Issue for logo storage: #1390

@sloede sloede requested a review from gregorgassner April 12, 2023 10:47
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@jlchan jlchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sloede the logos don't all fit on one line - do you mind if I change the widths?

Screen Shot 2023-04-12 at 10 12 00 AM

README.md Outdated Show resolved Hide resolved
@sloede
Copy link
Member Author

sloede commented Apr 12, 2023

@sloede the logos don't all fit on one line - do you mind if I change the widths?

Not at all. However, instead of making them all the same width, could you try making them approximately the same size in the eyeball norm? Right now, the NSF Logo is massive (since it has only large letters and nearly no white space in the margins), while the DFG and ERC logos already feel "cramped".

If it turns out that the logos do not look good anymore on a single line, we can also consider to deliberately put them on two lines.

@jlchan
Copy link
Contributor

jlchan commented Apr 12, 2023

Modified the formatting a little more and tried a new NSF logo. I think that helps the NSF logo, but now the Swedish Research Council looks a little odd now compared to the rest.

@sloede
Copy link
Member Author

sloede commented Apr 12, 2023

The acknowledgments section now looks like this:
image

Documenter.jl does not allow HTML formatting, so it is no easy feat to put the logos there such that it looks nice - if someone wants to give it a try, please go ahead; for now I just synchronized the texts.

@sloede sloede marked this pull request as ready for review April 12, 2023 16:17
@sloede sloede requested a review from jlchan April 12, 2023 16:18
jlchan
jlchan previously approved these changes Apr 12, 2023
Copy link
Contributor

@jlchan jlchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@sloede sloede changed the title WIP: Add funding agency logos and update acknowledgements Add funding agency logos and update acknowledgements Apr 12, 2023
Copy link
Member

@andrewwinters5000 andrewwinters5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for taking care of this @sloede!

@sloede sloede merged commit 601af82 into main Apr 13, 2023
@sloede sloede deleted the msl/funding-agencies branch April 13, 2023 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants