Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIB: Subcell limiting with IDP and MCL approach #1502

Draft
wants to merge 558 commits into
base: main
Choose a base branch
from

Merge branch 'main' into subcell-limiting

c7263f7
Select commit
Loading
Failed to load commit list.
Draft

WIB: Subcell limiting with IDP and MCL approach #1502

Merge branch 'main' into subcell-limiting
c7263f7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Oct 22, 2024 in 1s

96.30% (-0.06%) compared to 4a81e00

View this Pull Request on Codecov

96.30% (-0.06%) compared to 4a81e00

Details

Codecov Report

Attention: Patch coverage is 95.08434% with 102 lines in your changes missing coverage. Please review.

Project coverage is 96.30%. Comparing base (4a81e00) to head (c7263f7).

Files with missing lines Patch % Lines
src/solvers/dgsem_tree/dg_2d_subcell_limiters.jl 92.30% 58 Missing ⚠️
src/callbacks_step/stepsize_dg2d.jl 67.24% 19 Missing ⚠️
src/callbacks_step/limiting_analysis.jl 92.86% 6 Missing ⚠️
src/callbacks_step/limiting_analysis_2d.jl 93.42% 5 Missing ⚠️
src/solvers/dgsem_tree/subcell_limiters.jl 95.18% 4 Missing ⚠️
src/equations/compressible_euler_2d.jl 94.55% 3 Missing ⚠️
src/time_integration/methods_SSP.jl 91.18% 3 Missing ⚠️
...solvers/dgsem_structured/dg_2d_subcell_limiters.jl 98.57% 2 Missing ⚠️
...es/structured_2d_dgsem/elixir_euler_double_mach.jl 96.67% 1 Missing ⚠️
...tructured_2d_dgsem/elixir_euler_double_mach_MCL.jl 96.67% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1502      +/-   ##
==========================================
- Coverage   96.36%   96.30%   -0.06%     
==========================================
  Files         477      500      +23     
  Lines       37753    39791    +2038     
==========================================
+ Hits        36378    38319    +1941     
- Misses       1375     1472      +97

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov