Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node-level visualization support for coefficients of Subcell limiting #1611

Merged
merged 14 commits into from
Oct 18, 2023
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/callbacks_step/save_solution_dg.jl
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,6 @@ function save_solution_file(u, time, dt, timestep,
n_vars = size(data, 1)
end

# TODO: In trixi2txt, the data file is read; including node_variables for every mesh.
# So, do we need node_variables here as well?
if HDF5.has_parallel()
save_solution_file_parallel(data, time, dt, timestep, n_vars, mesh, equations,
dg, cache, solution_variables, filename,
Expand Down
1 change: 0 additions & 1 deletion src/solvers/dgsem_tree/subcell_limiters.jl
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,6 @@ end
function get_node_variables!(node_variables, limiter::SubcellLimiterIDP,
::VolumeIntegralSubcellLimiting, equations)
node_variables[:alpha_limiter] = limiter.cache.subcell_limiter_coefficients.alpha
bennibolm marked this conversation as resolved.
Show resolved Hide resolved
# Note: The coefficients are uninitialized in the first solution file.
return nothing
end
end # @muladd
2 changes: 2 additions & 0 deletions src/time_integration/methods_SSP.jl
Original file line number Diff line number Diff line change
Expand Up @@ -237,5 +237,7 @@ function Base.resize!(semi, volume_integral::VolumeIntegralSubcellLimiting, new_
# Resize container subcell_limiter_coefficients
@unpack limiter = volume_integral
resize!(limiter.cache.subcell_limiter_coefficients, new_size)
(; alpha) = limiter.cache.subcell_limiter_coefficients
alpha .= zero(eltype(alpha))
bennibolm marked this conversation as resolved.
Show resolved Hide resolved
end
end # @muladd