-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add load_timestep! for restart setup #1614
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, this looks already very good! Just two minor comments to resolve, then this is GTM!
Co-authored-by: Michael Schlottke-Lakemper <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot!
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1614 +/- ##
=======================================
Coverage 92.94% 92.94%
=======================================
Files 416 416
Lines 34065 34068 +3
=======================================
+ Hits 31661 31664 +3
Misses 2404 2404
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
In every restart setup we have to get the last time index and set the number of accepted steps in way:
It would be useful to combine these lines into one function
load_timestep!(integrator, restart_filename)