Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add load_timestep! for restart setup #1614

Merged
merged 8 commits into from
Sep 12, 2023

Conversation

ArseniyKholod
Copy link
Contributor

@ArseniyKholod ArseniyKholod commented Aug 25, 2023

In every restart setup we have to get the last time index and set the number of accepted steps in way:

integrator.iter = load_timestep(restart_filename)
integrator.stats.naccept = integrator.iter 

It would be useful to combine these lines into one function load_timestep!(integrator, restart_filename)

@github-actions
Copy link
Contributor

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

@ArseniyKholod ArseniyKholod requested a review from sloede August 30, 2023 09:19
Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, this looks already very good! Just two minor comments to resolve, then this is GTM!

src/callbacks_step/save_restart.jl Outdated Show resolved Hide resolved
Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

@sloede sloede enabled auto-merge (squash) August 30, 2023 10:06
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (27d4fd1) 92.94% compared to head (74e42bc) 92.94%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1614   +/-   ##
=======================================
  Coverage   92.94%   92.94%           
=======================================
  Files         416      416           
  Lines       34065    34068    +3     
=======================================
+ Hits        31661    31664    +3     
  Misses       2404     2404           
Flag Coverage Δ
unittests 92.94% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/Trixi.jl 43.48% <ø> (ø)
src/callbacks_step/save_restart.jl 91.53% <100.00%> (+0.45%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ranocha ranocha disabled auto-merge September 12, 2023 15:54
@ranocha ranocha enabled auto-merge (squash) September 12, 2023 15:55
@ranocha ranocha merged commit d206b76 into trixi-framework:main Sep 12, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants