Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some multi-threading improvements #1630

Merged
merged 3 commits into from
Sep 12, 2023
Merged

Some multi-threading improvements #1630

merged 3 commits into from
Sep 12, 2023

Conversation

ranocha
Copy link
Member

@ranocha ranocha commented Sep 12, 2023

I improved multi-threading a bit

  • Fix multi-threading for parabolic terms on ARM (such as Apple M series processors)
  • Reduce allocations a bit

See the commit messages for more details.

On ARM, the previous versions resulted in
  cfunction: closures are not supported on this platform
With this change, everything seems to work fine locally.
At least test/test_threaded.jl runs fine with two threads.
Polyester.jl passes arrays as pointer arrays to the closures without requiring allocations.
More complicated structs may still require allocations, so unpacking some arrays before entering a threaded loop can reduce allocations.
@ranocha ranocha added bug Something isn't working parallelization Related to MPI, threading, tasks etc. labels Sep 12, 2023
@github-actions
Copy link
Contributor

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

@ranocha ranocha requested a review from sloede September 12, 2023 06:54
sloede
sloede previously approved these changes Sep 12, 2023
Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks!

@sloede
Copy link
Member

sloede commented Sep 12, 2023

(you need to run the formatter)

@ranocha ranocha enabled auto-merge (squash) September 12, 2023 07:09
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage: 93.22% and project coverage change: -5.02% ⚠️

Comparison is base (953f88a) 96.14% compared to head (c217951) 91.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1630      +/-   ##
==========================================
- Coverage   96.14%   91.13%   -5.02%     
==========================================
  Files         414      414              
  Lines       33942    33943       +1     
==========================================
- Hits        32633    30931    -1702     
- Misses       1309     3012    +1703     
Flag Coverage Δ
unittests 91.13% <93.22%> (-5.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/solvers/dgsem_tree/dg_3d_parabolic.jl 92.65% <82.61%> (+0.07%) ⬆️
src/solvers/dgmulti/dg_parabolic.jl 90.34% <100.00%> (+0.05%) ⬆️
src/solvers/dgsem_tree/dg_1d_parabolic.jl 94.44% <100.00%> (+0.13%) ⬆️
src/solvers/dgsem_tree/dg_2d_parabolic.jl 95.95% <100.00%> (+0.04%) ⬆️

... and 56 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ranocha ranocha merged commit 7791faa into main Sep 12, 2023
29 of 31 checks passed
@ranocha ranocha deleted the hr/threading branch September 12, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working parallelization Related to MPI, threading, tasks etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants