Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new tutorial on custom RHS functions and semidiscretizations #1633

Merged
merged 16 commits into from
Sep 13, 2023

Conversation

ranocha
Copy link
Member

@ranocha ranocha commented Sep 12, 2023

This is a feature that has often been asked for on Slack/Discourse etc. Thus, I wrote a little tutorial explaining the concept of our RHS function and semidiscretization in Trixi.jl. In particular, it is now documented and becomes a part of the public API of Trixi.jl.

@j-salmeron Does this help you with your problem?

@ranocha ranocha added the documentation Improvements or additions to documentation label Sep 12, 2023
@ranocha ranocha requested a review from sloede September 12, 2023 13:17
@github-actions
Copy link
Contributor

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, and impressively detailed - I think this is going to be very helpful! Just a few suggestions, then it's good to go imho

docs/literate/make.jl Show resolved Hide resolved
docs/literate/src/files/custom_semidiscretization.jl Outdated Show resolved Hide resolved
docs/literate/src/files/custom_semidiscretization.jl Outdated Show resolved Hide resolved
@ranocha ranocha requested a review from sloede September 13, 2023 08:41
@ranocha
Copy link
Member Author

ranocha commented Sep 13, 2023

@sloede I also added the package versions used in the tutorial in 7747f99. I will create a new PR doing that for the other tutorials as well.

Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ranocha
Copy link
Member Author

ranocha commented Sep 13, 2023

LGTM!

Thanks!

@ranocha ranocha merged commit 32d837b into main Sep 13, 2023
4 checks passed
@ranocha ranocha deleted the hr/semidiscretization branch September 13, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants