Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for Documenter to 1 for package docs, (keep existing compat) #1641

Merged

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the Documenter package from 0.27 to 0.27, 1 for package docs.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@ranocha ranocha force-pushed the compathelper/new_version/2023-09-16-00-06-25-724-01651153356 branch from 9e92c82 to 8ae18c3 Compare September 16, 2023 00:06
@sloede
Copy link
Member

sloede commented Sep 19, 2023

The Trixi.jl API reference file is ~600 KiB large, which causes Documenter v1 to error (see here). I suggest to increase the threshold to 1 MiB for now and to open an issue about finding a sensible way to split this into multiple files.

sloede
sloede previously approved these changes Sep 19, 2023
Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the documentation build passes

@ranocha ranocha merged commit a64004d into main Sep 19, 2023
4 checks passed
@ranocha ranocha deleted the compathelper/new_version/2023-09-16-00-06-25-724-01651153356 branch September 19, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants