Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for SciMLBase to 2, (keep existing compat) #1646

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the SciMLBase package from 1.90 to 1.90, 2.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@ranocha ranocha force-pushed the compathelper/new_version/2023-09-23-00-05-36-210-02172124014 branch from 5bfc1aa to ce43eb5 Compare September 23, 2023 00:05
@codecov
Copy link

codecov bot commented Sep 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: +8.26% 🎉

Comparison is base (0b4bf98) 87.91% compared to head (ce43eb5) 96.16%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1646      +/-   ##
==========================================
+ Coverage   87.91%   96.16%   +8.26%     
==========================================
  Files         418      418              
  Lines       34205    34229      +24     
==========================================
+ Hits        30068    32915    +2847     
+ Misses       4137     1314    -2823     
Flag Coverage Δ
unittests 96.16% <ø> (+8.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 52 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sloede
Copy link
Member

sloede commented Sep 23, 2023

I don't understand the error. By itself, it is super unhelpful, but I also do not see why a bump in the SciMLBase version would affect this issue in the first place.

Flux v0.14 requires Julia v1.9, thus we allow also certain v0.13.x versions. However, some other requirement (which unfortunately is not shown in the error message), seems to demand Flux v0.14. If this were the case, then obviously there is an irreconcilable version conflict. However, as I said before, I don't understand where the requirement is coming from.

@ranocha
Copy link
Member

ranocha commented Sep 26, 2023

This is a CompatHelper PR. You can see

[ Info: This is a Dependabot/CompatHelper job, so force_latest_compatible_version has been set to true

just a few lines above the error you pointed out. I just triggered a PR manually to run CI with the new version of SciMLBase.jl. Let's see whether it works there.

@ranocha ranocha deleted the compathelper/new_version/2023-09-23-00-05-36-210-02172124014 branch September 26, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants