-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable save solution with time intervals for SimpleIntegratorSSP #1677
Conversation
…k using time intervals
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1677 +/- ##
==========================================
+ Coverage 94.67% 96.23% +1.56%
==========================================
Files 436 436
Lines 35166 35210 +44
==========================================
+ Hits 33292 33882 +590
+ Misses 1874 1328 -546
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…mpleIntegratorSSP)`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
This PR implements some modifications to
SimpleIntegratorSSP
, such that SaveSolutionCallback can be used with time intervals (keyworddt
) instead of time-step intervals (keywordinterval
).