-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add compat bounds for stdlibs #1711
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Note that they recently updated the PSA and are now (IMHO) somewhat confusingly also recommend to set the compat bound to 1 for packages supporting Julia 1.4 or higher. Since CompatHelper still wants to set bounds to 1, maybe we should do so as well for the time being at least? |
Done |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1711 +/- ##
===========================================
- Coverage 83.00% 72.60% -10.40%
===========================================
Files 431 431
Lines 34665 34637 -28
===========================================
- Hits 28772 25145 -3627
- Misses 5893 9492 +3599
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I added compat bounds for stdlibs since we cannot register new versions of Trixi.jl without them. I followed the recommendation in https://discourse.julialang.org/t/psa-compat-requirements-in-the-general-registry-are-changing/104958 since we didn't get any response in JuliaRegistries/TagBot#292.
The only exception to the rule above is Downloads - which is available in Julia v1.8 only as v1.6 and not v1.8 as usual...
Closes #1693, closes #1694