-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the wet/dry test for SWE #1727
Fix the wet/dry test for SWE #1727
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@patrickersing format check fails :-) |
@sloede I should probably add this automatic check from the style guide. It seems like the "Apply formatter"-commit is becoming part of my workflow 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
The goal of this PR is to fix the failing tests for the elixir_shallowwater_well_balanced_wet_dry.jl.
This test was observed to fail for CI runs on Intel Xeon Platinum CPUs. The L_inf error in this test seems to be highly sensitive to the specific CPU used in the run. In a sample of CI runs the following errors have been observed:
As the differences are negligible and seem to depend only on the specific CPU, this PR adjusts the absolute tolerance of this test from
atol=500*eps()
toatol=1000*eps()
such that the test passes on the Intel Xeon Platinum CPUs.