-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch (back) to Einfeldt wave-speed estimate from paper #1751
Switch (back) to Einfeldt wave-speed estimate from paper #1751
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1751 +/- ##
=======================================
Coverage 93.53% 93.53%
=======================================
Files 431 431
Lines 34853 34853
=======================================
Hits 32598 32598
Misses 2255 2255
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Downstream CI fails due to JuliaVTK/ReadVTK.jl#49. I'll merge this PR |
Due to the breaking change in #1708
the wave speed estimate now being used ("true"
naive
) in the 1D HLLC flux for MHD is actually not the desired one (Einfeldt).This change takes care of this.