-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove interfaces
and boundaries
from cache_parabolic
#1754
base: main
Are you sure you want to change the base?
Remove interfaces
and boundaries
from cache_parabolic
#1754
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1754 +/- ##
==========================================
- Coverage 96.27% 86.60% -9.67%
==========================================
Files 438 438
Lines 35623 35609 -14
==========================================
- Hits 34294 30836 -3458
- Misses 1329 4773 +3444
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@jlchan thanks for starting working on this! Sorry for not helping out on this, I thought (based on a comment during one of the Trixi meetings) that merging the 3D functionality would come first prior to addressing possible optimizations. Anyways, feel free to ask for a review once you are done with the optimizations. |
Good point @DanielDoehring. We can merge 3D first and simply use this as a CI testing PR until then. |
Having merged #1765 we can now turn our attention on this. |
Addresses step 3 of #1674