-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed cons2entropy
files and implemented entropy2cons
for CompressibleEulerMulticomponent1D
and CompressibleEulerMulticomponent2D
#1767
Fixed cons2entropy
files and implemented entropy2cons
for CompressibleEulerMulticomponent1D
and CompressibleEulerMulticomponent2D
#1767
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
…ulticomponent euler 1d and 2d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I've added some suggestions for comments
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1767 +/- ##
==========================================
+ Coverage 96.23% 96.24% +0.01%
==========================================
Files 436 436
Lines 35210 35297 +87
==========================================
+ Hits 33882 33969 +87
Misses 1328 1328
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-authored-by: Jesse Chan <[email protected]>
Co-authored-by: Jesse Chan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like most of the changes to the tests are just due to formatting changes needed to pass CI.
I added two comments to the relevant sections that were actually changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes #1715 based on the equation on page 5 from this paper and equations on page 21 and 22 from Christoph Czernik's thesis.