Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: T8codeMesh backend with MPI support #1803

Merged
merged 241 commits into from
Jan 31, 2024
Merged

Feature: T8codeMesh backend with MPI support #1803

merged 241 commits into from
Jan 31, 2024

Conversation

jmark
Copy link
Contributor

@jmark jmark commented Jan 12, 2024

This is the fully-featured T8codeMesh backend with MPI support in 2D/3D.

Before this PR is merged in the PR about 3D should be merged first. #1535

Johannes Markert and others added 30 commits May 5, 2023 16:29
Initial commit for the new feature using t8code as meshing backend.
db1ea6b
@jmark
Delete t8code_2d_dgsem
2cac6c9
Added new examples and tests. Testing updates for T8code.jl.
1bb2061
Merge branch 'feature-t8code' of github.com:trixi-framework/Trixi.jl …
ba920cd 
…into feature-t8code
Worked in the comments.
1cab250
@jmark
Merge branch 'main' into feature-t8code
edf6a91
Fixed spelling.
cdced17
@jmark @ranocha
Update src/auxiliary/auxiliary.jl
d02d32e 
Co-authored-by: Hendrik Ranocha <[email protected]>
Added whitespace in Unions.
7c01df0
Adapted commented out code block reporting the no. of elements per le…
e6cd1ab 
…vel.
Added dummy save mesh support for .
0abdcd9
Added test .
10ac87d
Added to method signature.
349136a
Deleted unnecessary comments.
3e47616
Removed commented out tests.
fe6d874
Fixed Morton ordering bug in 2D at mortar interfaces.
d5d6298
Disabled save_solution callbacks and added more tests.
9c0db6f
Added more tests.
1440f90
@jmark
Merge branch 'main' into feature-t8code
85a34df
Updated code according to the review.
068558f
@jmark
Merge branch 'main' into feature-t8code
1fab9b9
@jmark
Merge branch 'main' into feature-t8code
6dcca7b
@jmark @ranocha
Update src/auxiliary/t8code.jl
497f957 
Co-authored-by: Hendrik Ranocha <[email protected]>
@jmark @ranocha
Update src/auxiliary/t8code.jl
4a958c4 
Co-authored-by: Hendrik Ranocha <[email protected]>
@jmark @ranocha
Update src/auxiliary/t8code.jl
3d869b0 
Co-authored-by: Hendrik Ranocha <[email protected]>
@jmark @ranocha
Update src/auxiliary/t8code.jl
c04b0f0 
Co-authored-by: Hendrik Ranocha <[email protected]>
@jmark @ranocha
Update src/meshes/t8code_mesh.jl
5396b87 
Co-authored-by: Hendrik Ranocha <[email protected]>
@jmark @ranocha
Update src/meshes/t8code_mesh.jl
095fdbc 
Co-authored-by: Hendrik Ranocha <[email protected]>
@jmark @ranocha
Update src/meshes/t8code_mesh.jl
3222693 
Co-authored-by: Hendrik Ranocha <[email protected]>
@jmark @ranocha
Update src/meshes/t8code_mesh.jl
db52949 
Co-authored-by: Hendrik Ranocha <[email protected]>
@benegee
Copy link
Contributor

benegee commented Jan 29, 2024

Nice work! You can ping me later for a final review when the other comments are resolved. Thanks also to the reviewers!

That is now, @ranocha. Many thanks in advance!

ranocha
ranocha requested changes Jan 29, 2024
View reviewed changes
Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I did not review the lower-level details of the changes in src/meshes/t8code_mesh.jl in details - assuming that @bgeihe et al. did that already.

src/auxiliary/auxiliary.jl Outdated Show resolved Hide resolved
src/callbacks_step/amr_dg2d.jl Outdated Show resolved Hide resolved
src/callbacks_step/amr_dg3d.jl Outdated Show resolved Hide resolved
src/solvers/dgsem_t8code/containers.jl Outdated Show resolved Hide resolved
test/test_mpi.jl Outdated Show resolved Hide resolved
src/meshes/t8code_mesh.jl Show resolved Hide resolved
src/meshes/t8code_mesh.jl Show resolved Hide resolved
src/meshes/t8code_mesh.jl Outdated Show resolved Hide resolved
src/meshes/t8code_mesh.jl Outdated Show resolved Hide resolved
@jmark
Copy link
Contributor Author

jmark commented Jan 30, 2024

@ranocha @bgeihe All remaining questions resolved. Anything else to do?

@benegee benegee requested a review from ranocha January 30, 2024 14:57
@ranocha ranocha enabled auto-merge (squash) January 31, 2024 13:45
@ranocha ranocha merged commit d53fdb5 into main Jan 31, 2024
36 checks passed
@ranocha ranocha deleted the feature-t8code-mpi branch January 31, 2024 15:49
@JoshuaLampert
Copy link
Member

Nice, great work, @jmark!

benegee added a commit that referenced this pull request Mar 7, 2024
@benegee
Update parallelization.md
9f0d033 
MPI support in T8code came with #1803
@benegee benegee mentioned this pull request Mar 7, 2024
Merged
ranocha pushed a commit that referenced this pull request Mar 7, 2024
@benegee
Update parallelization.md (#1864)
c4bf3df 
MPI support in T8code came with #1803
@andrewwinters5000 andrewwinters5000 mentioned this pull request Aug 21, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benegee benegee benegee left review comments

@lchristm lchristm lchristm left review comments

@JoshuaLampert JoshuaLampert JoshuaLampert left review comments

@sloede sloede sloede left review comments

@ranocha ranocha ranocha approved these changes

@DanielDoehring DanielDoehring DanielDoehring left review comments

Assignees

@ranocha ranocha

@benegee benegee

Labels
enhancement New feature or request parallelization Related to MPI, threading, tasks etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@jmark @benegee @DanielDoehring @JoshuaLampert @sloede @ranocha @lchristm @jlchan @apey236 @patrickersing