Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump crate-ci/typos from 1.16.26 to 1.18.0 #1826

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 1, 2024

Bumps crate-ci/typos from 1.16.26 to 1.18.0.

Release notes

Sourced from crate-ci/typos's releases.

v1.18.0

[1.18.0] - 2024-02-01

Fixes

v1.17.2

[1.17.2] - 2024-01-19

Fixes

  • Treat *.ts as typescript, not typoscript
  • Remove file type definitions that aren't used

v1.17.1

[1.17.1] - 2024-01-12

Features

  • First attempt at aarch64 for Mac

v1.17.0

[1.17.0] - 2024-01-03

Fixes

Changelog

Sourced from crate-ci/typos's changelog.

[1.18.0] - 2024-02-01

Fixes

[1.17.2] - 2024-01-19

Fixes

  • Treat *.ts as typescript, not typoscript
  • Remove file type definitions that aren't used

[1.17.1] - 2024-01-12

Features

  • First attempt at aarch64 for Mac

[1.17.0] - 2024-01-03

Fixes

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Feb 1, 2024
Copy link
Contributor

github-actions bot commented Feb 1, 2024

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

@sloede
Copy link
Member

sloede commented Feb 1, 2024

There's mostly complaints about leafs vs leaves. It seems to be mostly in parabolic/t8code territory: https://github.com/trixi-framework/Trixi.jl/actions/runs/7744103473/job/21117076411?pr=1826#step:3:40

@jmark @DanielDoehring Do you know whether this is an upstream issue (since t8code/p4est actually calls something "leafs" instead of "leaves") or just with us and we should fix it?

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e2c92f3) 92.14% compared to head (c17a7a3) 76.17%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1826       +/-   ##
===========================================
- Coverage   92.14%   76.17%   -15.97%     
===========================================
  Files         455      455               
  Lines       36374    36324       -50     
===========================================
- Hits        33514    27668     -5846     
- Misses       2860     8656     +5796     
Flag Coverage Δ
unittests 76.17% <ø> (-15.97%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.16.26 to 1.18.0.
- [Release notes](https://github.com/crate-ci/typos/releases)
- [Changelog](https://github.com/crate-ci/typos/blob/master/CHANGELOG.md)
- [Commits](crate-ci/typos@v1.16.26...v1.18.0)

---
updated-dependencies:
- dependency-name: crate-ci/typos
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/github_actions/crate-ci/typos-1.18.0 branch from c17a7a3 to 8e34afc Compare February 1, 2024 17:07
@JoshuaLampert
Copy link
Member

As far as I can tell, all the complaints are for variable names, which can be fixed here. However, in T8code.jl there are also exported function names with leafs create-ci/typos complains about, which are, however, not used in Trixi.jl. Thus, I would suggest to fix the typos here, but skip them in T8code.jl via the .typos.toml.

@ranocha ranocha merged commit 7f7f058 into main Feb 2, 2024
30 of 31 checks passed
@ranocha ranocha deleted the dependabot/github_actions/crate-ci/typos-1.18.0 branch February 2, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants