hack to allow passing functions defined in the REPL to Trixi.run etc. #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #184 +/- ##
=======================================
Coverage 91.68% 91.68%
=======================================
Files 31 31
Lines 6853 6855 +2
=======================================
+ Hits 6283 6285 +2
Misses 570 570
Continue to review full report at Codecov.
|
sloede
approved these changes
Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Taal (#177) will take some time and I want to use this feature right now, I've hacked a possibility allowing users to define initial conditions and source terms in the REPL before passing them as keyword arguments to Trixi.run etc.
I would like to get this merged and make a new minor release afterwards.