-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix formatter to older version #1843
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Should the scripts in https://github.com/trixi-framework/Trixi.jl/blob/main/utils/trixi-format.jl |
Good suggestion, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current changes to scripts in utils
give me an unexpected ERROR: type Context has no field version
. This is a working alternative.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1843 +/- ##
==========================================
- Coverage 96.38% 96.20% -0.18%
==========================================
Files 455 455
Lines 36391 36391
==========================================
- Hits 35074 35009 -65
- Misses 1317 1382 +65
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-authored-by: Arpit Babbar <[email protected]>
Co-authored-by: Arpit Babbar <[email protected]>
Thanks again! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The formatter still fails on the util
formatter scripts because the lines are too long.
Co-authored-by: Joshua Lampert <[email protected]>
As an alternative to #1842, I fixed the version of JuliaFormatter to an older one.