-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update benchmarking docs #1849
Update benchmarking docs #1849
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Just submitted a run on julia |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update, this works now!
I added this information on RAM since one of my first runs crashed due to too little RAM allowed for each thread.
I think this is valuable information for anyone using this benchmarking in conjunction with a workload manager such as SLURM.
Co-authored-by: Daniel Doehring <[email protected]>
Great, thanks! |
I made some changes to the benchmarking setups (which were bit-rotten...). This fix should document the necessary steps to benchmark a PR. Please let me know if this works for you, @DanielDoehring