Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upwind SBP on curved meshes #1857
Upwind SBP on curved meshes #1857
Changes from 19 commits
a6ba38e
3aa5ea4
068ebd1
4324ec6
d28e814
f1cabf8
a8cf691
ad31bdc
a622fb6
75d284d
376e84d
40f6547
b836c21
b2a4a2d
5f6238e
49c87c5
22fbda8
5923392
43fd5b1
c11af11
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fine for now but we should keep track of it so that someone can improve this later. I added it to the list in #1284
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, that sounds reasonable. I thought about throwing an error if a user attempts to set anything different for the
xmin
andxmax
values. Would this maybe be overkill? Alternatively, we could maybe add "under the hood" an affine map of the user desiredxmin
andxmax
to the [-1,1] interval. However, I am hot sure if this would mess with plotting or post processing later.