-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
force new FFMPEG.jl version for tests #1858
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
CI is still running, so it looks like this hotfix works for now. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1858 +/- ##
=======================================
Coverage 96.28% 96.28%
=======================================
Files 438 438
Lines 35386 35386
=======================================
Hits 34071 34071
Misses 1315 1315
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This should fix our recent CI failures on Windows and macOS related to ancient versions of FFMPEG, e.g.,
It looks like the reason is that the package manager prefers a newer version of FFMPEG_jll that is not yet allowed by FFMPEG.jl (but there is the PR JuliaIO/FFMPEG.jl#59):
I was able to reproduce getting the old version as follows.
Manifest.toml
and use the current clone of Trixi.jljulia +1.9 --project=.
(Trixi) pkg> build
julia> ENV["TRIXI_TEST"] = "none"
(Trixi) pkg> test Trixi
Then, I inspected the generated
Manifest.toml
:Updating yields
Let's see whether it works.
Closes #1852