Check BCs for periodicity for periodic Tree & Structured meshes

src/meshes/tree_mesh.jl

@@ -228,5 +228,8 @@ function total_volume(mesh::TreeMesh)
     return mesh.tree.length_level_0^ndims(mesh)
 end
 
+isperiodic(mesh::TreeMesh) = isperiodic(mesh.tree)
+isperiodic(mesh::TreeMesh, dimension) = isperiodic(mesh.tree, dimension)
+
 include("parallel_tree_mesh.jl")
 end # @muladd

src/semidiscretization/semidiscretization_hyperbolic.jl

@@ -72,6 +72,8 @@ function SemidiscretizationHyperbolic(mesh, equations, initial_condition, solver
     _boundary_conditions = digest_boundary_conditions(boundary_conditions, mesh, solver,
                                                       cache)
 
+    check_periodicity_mesh_boundary_conditions(mesh, _boundary_conditions)
+
     SemidiscretizationHyperbolic{typeof(mesh), typeof(equations),
                                  typeof(initial_condition),
                                  typeof(_boundary_conditions), typeof(source_terms),
@@ -210,6 +212,126 @@ function digest_boundary_conditions(boundary_conditions::AbstractArray, mesh, so
     throw(ArgumentError("Please use a (named) tuple instead of an (abstract) array to supply multiple boundary conditions (to improve performance)."))
 end
 
+# No checks for these meshes yet available
+function check_periodicity_mesh_boundary_conditions(mesh::Union{P4estMesh,
+                                                                UnstructuredMesh2D,
+                                                                T8CodeMesh,
+                                                                DGMultiMesh},
+                                                    boundary_conditions)
+end
+
+# No actions needed for periodic boundary conditions
+function check_periodicity_mesh_boundary_conditions(mesh::Union{TreeMesh,
+                                                                StructuredMesh},
+                                                    boundary_conditions::BoundaryConditionPeriodic)
+end
+
+function check_periodicity_mesh_boundary_conditions(mesh::Union{TreeMesh{1},
+                                                                StructuredMesh{1}},
+                                                    boundary_conditions::NamedTuple)
+    @unpack x_neg, x_pos = boundary_conditions
+    if isperiodic(mesh, 1) &&
+       (x_neg != BoundaryConditionPeriodic() ||
+        x_pos != BoundaryConditionPeriodic())
+        @error "For periodic mesh non-periodic boundary conditions are supplied.
+         The boundary conditions will be ignored and periodic boundary conditions are used."
+    end
+end
+
+function check_periodicity_mesh_boundary_conditions(mesh::Union{TreeMesh{1},
+                                                                StructuredMesh{1}},
+                                                    boundary_conditions::NTuple{2, Any})
+    if isperiodic(mesh, 1) &&
+       (boundary_conditions[1] != BoundaryConditionPeriodic() ||
+        boundary_conditions[2] != BoundaryConditionPeriodic())
+        @error "For periodic mesh non-periodic boundary conditions are supplied.
+         The boundary conditions will be ignored and periodic boundary conditions are used."
+    end
+end
+
+function check_periodicity_mesh_boundary_conditions(mesh::Union{TreeMesh{2},
+                                                                StructuredMesh{2}},
+                                                    boundary_conditions::NamedTuple)
+    @unpack x_neg, x_pos, y_neg, y_pos = boundary_conditions
+    if isperiodic(mesh, 1) &&
+       (x_neg != BoundaryConditionPeriodic() ||
+        x_pos != BoundaryConditionPeriodic())
+        @error "For periodic mesh non-periodic boundary conditions in x-direction are supplied.
+         The boundary conditions will be ignored and periodic boundary conditions are used."
+    end
+    if isperiodic(mesh, 2) &&
+       (y_neg != BoundaryConditionPeriodic() ||
+        y_pos != BoundaryConditionPeriodic())
+        @error "For periodic mesh non-periodic boundary conditions in y-direction are supplied.
+         The boundary conditions will be ignored and periodic boundary conditions are used."
+    end
+end
+
+function check_periodicity_mesh_boundary_conditions(mesh::Union{TreeMesh{2},
+                                                                StructuredMesh{2}},
+                                                    boundary_conditions::NTuple{4, Any})
+    if isperiodic(mesh, 1) &&
+       (boundary_conditions[1] != BoundaryConditionPeriodic() ||
+        boundary_conditions[2] != BoundaryConditionPeriodic())
+        @error "For periodic mesh non-periodic boundary conditions in x-direction are supplied.
+         The boundary conditions will be ignored and periodic boundary conditions are used."
+    end
+    if isperiodic(mesh, 2) &&
+       (boundary_conditions[3] != BoundaryConditionPeriodic() ||
+        boundary_conditions[4] != BoundaryConditionPeriodic())
+        @error "For periodic mesh non-periodic boundary conditions in y-direction are supplied.
+         The boundary conditions will be ignored and periodic boundary conditions are used."
+    end
+end
+
+function check_periodicity_mesh_boundary_conditions(mesh::Union{TreeMesh{3},
+                                                                StructuredMesh{3}},
+                                                    boundary_conditions::NamedTuple)
+    @unpack x_neg, x_pos, y_neg, y_pos, z_neg, z_pos = boundary_conditions
+    if isperiodic(mesh, 1) &&
+       (x_neg != BoundaryConditionPeriodic() ||
+        x_pos != BoundaryConditionPeriodic())
+        @error "For periodic mesh non-periodic boundary conditions in x-direction are supplied.
+         The boundary conditions will be ignored and periodic boundary conditions are used."
+    end
+    if isperiodic(mesh, 2) &&
+       (y_neg != BoundaryConditionPeriodic() ||
+        y_pos != BoundaryConditionPeriodic())
+        @error "For periodic mesh non-periodic boundary conditions in y-direction are supplied.
+         The boundary conditions will be ignored and periodic boundary conditions are used."
+    end
+    if isperiodic(mesh, 3) &&
+       (z_neg != BoundaryConditionPeriodic() ||
+        z_pos != BoundaryConditionPeriodic())
+        @error "For periodic mesh non-periodic boundary conditions in z-direction are supplied.
+         The boundary conditions will be ignored and periodic boundary conditions are used."
+    end
+end
+
+function check_periodicity_mesh_boundary_conditions(mesh::Union{TreeMesh{3},
+                                                                StructuredMesh{3}},
+                                                    boundary_conditions::NTuple{6, Any})
+    @unpack x_neg, x_pos, y_neg, y_pos, z_neg, z_pos = boundary_conditions
+    if isperiodic(mesh, 1) &&
+       (boundary_conditions[1] != BoundaryConditionPeriodic() ||
+        boundary_conditions[2] != BoundaryConditionPeriodic())
+        @error "For periodic mesh non-periodic boundary conditions in x-direction are supplied.
+         The boundary conditions will be ignored and periodic boundary conditions are used."
+    end
+    if isperiodic(mesh, 2) &&
+       (boundary_conditions[3] != BoundaryConditionPeriodic() ||
+        boundary_conditions[4] != BoundaryConditionPeriodic())
+        @error "For periodic mesh non-periodic boundary conditions in y-direction are supplied.
+         The boundary conditions will be ignored and periodic boundary conditions are used."
+    end
+    if isperiodic(mesh, 3) &&
+       (boundary_conditions[5] != BoundaryConditionPeriodic() ||
+        boundary_conditions[6] != BoundaryConditionPeriodic())
+        @error "For periodic mesh non-periodic boundary conditions in z-direction are supplied.
+         The boundary conditions will be ignored and periodic boundary conditions are used."
+    end
+end
+
 function Base.show(io::IO, semi::SemidiscretizationHyperbolic)
     @nospecialize semi # reduce precompilation time
 

src/semidiscretization/semidiscretization_hyperbolic_parabolic.jl

@@ -136,6 +136,8 @@ function SemidiscretizationHyperbolicParabolic(mesh, equations, equations_parabo
     _boundary_conditions_parabolic = digest_boundary_conditions(boundary_conditions_parabolic,
                                                                 mesh, solver, cache)
 
+    check_periodicity_mesh_boundary_conditions(mesh, _boundary_conditions)
+
     cache_parabolic = (;
                        create_cache_parabolic(mesh, equations, equations_parabolic,
                                               solver, solver_parabolic, RealT,