Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump julia-actions/setup-julia from 1 to 2 #1895

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 1, 2024

Bumps julia-actions/setup-julia from 1 to 2.

Release notes

Sourced from julia-actions/setup-julia's releases.

v2.0.0 - Update to Node20

What's Changed

Note the rationale for the breaking change was discussed in julia-actions/setup-julia#209

Dependencies and misc

New Contributors

Full Changelog: julia-actions/setup-julia@v1.9.6...v2.0.0

v1.9.6: Fix Apple Silicon installation

What's Changed

Deps & CI

New Contributors

Full Changelog: julia-actions/setup-julia@v1.9.5...v1.9.6

v1.9.5: Maintain mtime of julia build to avoid re-precompilation

A big part of fixing JuliaLang/julia#50667 for julia <1.11 as maintaining the mtime of the julia source files means cached /compiled caches won't be invalidated in new runs where julia has been reinstalled.

What's Changed

Dep updates

... (truncated)

Commits
  • f225878 Add production dependencies & build
  • b96a572 Bump the version number to 2.0.0 in package.json and package-lock.json ...
  • 437a175 update to node20 (#209)
  • e9d953d Bump @​types/node from 20.11.16 to 20.11.30 (#226)
  • 4190528 Bump @​types/semver from 7.5.6 to 7.5.8 (#222)
  • 9acd04f Bump nock from 13.5.1 to 13.5.4 (#224)
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Apr 1, 2024
Copy link
Contributor

github-actions bot commented Apr 1, 2024

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

Bumps [julia-actions/setup-julia](https://github.com/julia-actions/setup-julia) from 1 to 2.
- [Release notes](https://github.com/julia-actions/setup-julia/releases)
- [Commits](julia-actions/setup-julia@v1...v2)

---
updated-dependencies:
- dependency-name: julia-actions/setup-julia
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/github_actions/julia-actions/setup-julia-2 branch from 150cfde to c00ec27 Compare April 2, 2024 07:32
@ranocha ranocha closed this Apr 2, 2024
@ranocha ranocha reopened this Apr 2, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 2, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@ranocha
Copy link
Member

ranocha commented Apr 2, 2024

I added the codecov secret to dependabot. Let's see whether CI passes now.

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.32%. Comparing base (641fde8) to head (c00ec27).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1895   +/-   ##
=======================================
  Coverage   96.32%   96.32%           
=======================================
  Files         445      445           
  Lines       35926    35926           
=======================================
  Hits        34605    34605           
  Misses       1321     1321           
Flag Coverage Δ
unittests 96.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ranocha ranocha merged commit 09600b5 into main Apr 3, 2024
46 of 73 checks passed
@ranocha ranocha deleted the dependabot/github_actions/julia-actions/setup-julia-2 branch April 3, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant