-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add preprocessing step to automate numbering in tutorial introduction #1901
Add preprocessing step to automate numbering in tutorial introduction #1901
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
I don't really know if this change is wanted but for me, it was annoying to update all the numbers when adding a new tutorial. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea! I've left some comments. It would also be great to get a feedback from @ArseniyKholod, since he's also been active writing tutorials...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and can be merged once @ArseniyKholod signs off as well 🙂
Thank you for the nice improvement of developer convenience 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Really good idea, it was annoying to change all indexes manually. LGTM!
Oh, just realized (again) that auto-merge doesn't work here. Please be so nice and merge it @sloede 😄 |
Right now, when someone wants to add a new tutorial, he has to update all following numbers within the introduction. This is done for instance in this PR.
The new preprocessing step automates the numbering.