-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Docs for new Users #1911
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for a small typo. It would be great to get some feedback from @knstmrd as well though!
Looks good to me! Thanks! |
Co-authored-by: Michael Schlottke-Lakemper <[email protected]>
This aims to tackle some of the feedback from #1907.
In particular, I seek to address
This overview however does not mention which type of fluxes (i.e. dispatching on normals or integer directions) are needed for which grid
Similarly, links [...] for the Structured Mesh to the "Structured mesh with curvilinear mapping" would also be helpful
Finally, I haven't seen it explicitly mentioned that TreeMesh makes the domain square?