Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read in capacity for parallel TreeMesh #1913

Merged
merged 7 commits into from
May 31, 2024
Merged

Conversation

benegee
Copy link
Contributor

@benegee benegee commented Apr 23, 2024

Fixes restarting with AMR and MPI.
Resolves #1912

fixes restarting with AMR and MPI
Copy link
Contributor

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.11%. Comparing base (76719a8) to head (9f27450).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1913   +/-   ##
=======================================
  Coverage   96.11%   96.11%           
=======================================
  Files         460      460           
  Lines       36926    36926           
=======================================
  Hits        35490    35490           
  Misses       1436     1436           
Flag Coverage Δ
unittests 96.11% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ranocha ranocha requested a review from sloede April 23, 2024 18:57
@ranocha
Copy link
Member

ranocha commented Apr 23, 2024

Can we get a CI test for this, please?

Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! As commented by @ranocha, would it be possible to add a test for this as well?

@DanielDoehring DanielDoehring added parallelization Related to MPI, threading, tasks etc. bug Something isn't working labels Apr 24, 2024
@benegee benegee requested review from JoshuaLampert May 29, 2024 21:20
JoshuaLampert
JoshuaLampert previously approved these changes May 30, 2024
Copy link
Member

@JoshuaLampert JoshuaLampert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

test/test_mpi_tree.jl Outdated Show resolved Hide resolved
Co-authored-by: Hendrik Ranocha <[email protected]>
@ranocha ranocha requested a review from sloede May 31, 2024 19:08
@ranocha ranocha merged commit bdb8180 into main May 31, 2024
38 checks passed
@ranocha ranocha deleted the bg/fix-treemesh-amr-mpi-restart branch May 31, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working parallelization Related to MPI, threading, tasks etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restart does not work with TreeMesh + AMR + MPI
5 participants