Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load current_filename for Unstructured2D and P4est Meshes #1923

Conversation

DanielDoehring
Copy link
Contributor

There was an inconsistency between the mesh types: For Structured and TreeMesh the current_filename variable was correctly set, while for P4est and Unstructured2D this was not the case.

I discovered this when restarting a simulation, from which I saved solutions for which no mesh was specified, resulting in error when applying Trixi2Vtk.

@DanielDoehring DanielDoehring added bug Something isn't working consistency Make Michael happy labels Apr 29, 2024
@DanielDoehring DanielDoehring requested a review from sloede April 29, 2024 13:12
Copy link
Contributor

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

@sloede
Copy link
Member

sloede commented Apr 29, 2024

can you maybe reopen this from a branch within Trixi.jl? Otherwise, can you please check if all errors are only codecov related?

@DanielDoehring
Copy link
Contributor Author

See #1924

@DanielDoehring DanielDoehring deleted the current_filenameUnstructured2DP4est branch April 29, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working consistency Make Michael happy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants