-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 1D DGMulti
GaussSBP
solver
#1930
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I just have a minor suggestion
Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thanks for the quick review! |
Codecov is failing but I would like to see whether CI covers the new code... |
Maybe you can push this branch to a branch in the main repo and open a new PR so that we don't have the problem with codecov? |
Sure, no problem |
* add 1D Gauss tensor product functionality * add 1D kronecker product fallback * add Burgers' shock capturing example * add test * format * Update examples/dgmulti_1d/elixir_burgers_gauss_shock_capturing.jl Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com> * add DOI --------- Co-authored-by: Hendrik Ranocha <mail@ranocha.de> Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
Superceded by #1932 |
Pull request was closed
* add 1D Gauss tensor product functionality * add 1D kronecker product fallback * add Burgers' shock capturing example * add test * format * Update examples/dgmulti_1d/elixir_burgers_gauss_shock_capturing.jl * add DOI --------- Co-authored-by: Hendrik Ranocha <mail@ranocha.de> Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
GaussSBP
solvers previously were only implemented in 2D and 3D. This PR adds 1D capabilities (using that sum factorization just reduces tomul!
in 1D).