-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add one-sided limiting for nonlinear variables to tutorial #1934
Add one-sided limiting for nonlinear variables to tutorial #1934
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1934 +/- ##
==========================================
+ Coverage 89.49% 92.32% +2.83%
==========================================
Files 453 453
Lines 36474 36485 +11
==========================================
+ Hits 32640 33682 +1042
+ Misses 3834 2803 -1031
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
In the future, please create your branch in the Trixi repo and not in a fork, at least until this ugly Codecov business is resolved. Thanks!
The one-sided local limiting for non-linear variables was merged in #1792. This PR updates the tutorial.