-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CompatHelper: bump compat for CairoMakie to 0.12 for package test, (keep existing compat) #1936
CompatHelper: bump compat for CairoMakie to 0.12 for package test, (keep existing compat) #1936
Conversation
…eep existing compat)
24257b4
to
22c71fb
Compare
…eep existing compat) (#1935) Co-authored-by: CompatHelper Julia <[email protected]>
Co-authored-by: Hendrik Ranocha <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1936 +/- ##
==========================================
- Coverage 96.09% 91.16% -4.94%
==========================================
Files 453 453
Lines 36481 36477 -4
==========================================
- Hits 35055 33251 -1804
- Misses 1426 3226 +1800
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The CI failure looks real to me:
@asinghvi17 Since you created #1937, do you have a suggestion how to fix this? |
Ah I didn't see that! Will look into it. |
Thanks a lot! |
* Fix old API usage for Camera3D * Update Project.toml * Update Project.toml * Update Project.toml
Do you know in which version the shading options were updated like this?
I would like to make sure that we don't get incompatible compatibility bounds in our |
This pull request changes the compat entry for the
CairoMakie
package from0.10
to0.10, 0.12
for package test.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.
TODO