-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add subcell limiting support for StructuredMesh #1942
Add subcell limiting support for StructuredMesh #1942
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1942 +/- ##
===========================================
- Coverage 89.49% 75.26% -14.23%
===========================================
Files 453 457 +4
Lines 36474 36681 +207
===========================================
- Hits 32640 27606 -5034
- Misses 3834 9075 +5241
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Due to issues with the code coverage test, continue this PR with a branch on upstream Trixi and not on my fork. #1946 |
This PR adds subcell limiting support for
Structuredmesh
.Getting the inverse Jacobian makes this PR a bit longer. That's because for TreeMesh,
inverse_jacobian
is fixed within one element, while it is different for each node for StructuredMesh.To avoid something like
and also avoid unnecessary calls of inverse jacobian in TreeMesh simulations, I dispatched for the mesh type and extracted the code
[...]
to an inner function (This is also done for e.g. the routineapply_jacobian!
).After this PR, it will be straight forward to add support for P4estMesh.
For now, there is no support for non-conservative systems.
TODO: