Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis: Build also for another dev branch and not on Julia nightly anymore #196

Merged
merged 1 commit into from
Oct 1, 2020

Conversation

ranocha
Copy link
Member

@ranocha ranocha commented Oct 1, 2020

I know that I've argued to build on Julia nightly in the past, but I think we should skip this now. It just costs time, in particular when multiple PRs are modified at the same time, while the benefits are comparably low. I've added the dev branch since I want to target that one while developing Taal in #187 etc.

@ranocha ranocha requested a review from sloede October 1, 2020 05:20
@codecov
Copy link

codecov bot commented Oct 1, 2020

Codecov Report

Merging #196 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #196   +/-   ##
=======================================
  Coverage   91.60%   91.60%           
=======================================
  Files          31       31           
  Lines        6958     6958           
=======================================
  Hits         6374     6374           
  Misses        584      584           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 645fe4a...a169033. Read the comment docs.

@sloede
Copy link
Member

sloede commented Oct 1, 2020

What's the purpose/intent of the dev branch? Do you want to use it as some sort of staging environment for large changes that require multiple development passes but should eventually be merged to master in one single motion?

@ranocha
Copy link
Member Author

ranocha commented Oct 1, 2020

Exactly! That's what I would like to do with Taal (#187).

@ranocha
Copy link
Member Author

ranocha commented Oct 1, 2020

In particular since you wanted to merge MPI into master first and we will build on that for Taal.

@ranocha ranocha merged commit c2d57f6 into master Oct 1, 2020
@ranocha ranocha deleted the hr/travis branch October 1, 2020 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants