Generalize Jin Xin relaxation #1961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
sloede
reviewed
May 29, 2024
| f_ll_base = get_block_components(u_ll, 2, equations) | ||
| f_rr_base = get_block_components(u_rr, 2, equations) | ||
| dissipation = SVector((sqrt_velocities .* (u_rr_base - u_ll_base))..., | ||
| (sqrt_velocities .* (f_rr_base + f_ll_base))..., |
There was a problem hiding this comment.
@ranocha Are you sure this is supposed to be a + and not a -, as it was in @gregorgassner's original implementation?
There was a problem hiding this comment.
Should be - - sorry, my fault 🙈
| f_rr_base = get_block_components(u_rr, 3, equations) | ||
| dissipation = SVector((sqrt_velocities .* (u_rr_base - u_ll_base))..., | ||
| zero(u_ll_base)..., | ||
| (sqrt_velocities .* (f_rr_base + f_ll_base))...) |
sloede
reviewed
May 29, 2024
| return max(sa[1],sa[2],sa[3],sa[4]), max(sb[1],sb[2],sb[3],sb[4]) | ||
| @inline function max_abs_speeds(u, equations::JinXinEquations{2}) | ||
| return ntuple(Val(ndims(equations))) do n | ||
| maximum(equations.sqrt_velocities_inv[n]) |
There was a problem hiding this comment.
Suggested change
| maximum(equations.sqrt_velocities_inv[n]) | |
| maximum(equations.sqrt_velocities[n]) |
Again, was this by accident or do you really think it should be the inverse of the sqrt of the velocities?
There was a problem hiding this comment.
No, should be without inv - looks like I hacked this stuff together too quickly
|
I decided to merge this as it is now but for now I reverted the behavior to what it was before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I drafted a generalized version of Jin Xin relaxation that should also work for other equations - at least the stuff in the
equationsdirectory, not the implicit stuff. How does that look to you, @sloede?