Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add StructuredMeshView to fluxes. #1986

Merged
merged 5 commits into from
Jul 3, 2024
Merged

Add StructuredMeshView to fluxes. #1986

merged 5 commits into from
Jul 3, 2024

Conversation

SimonCan
Copy link
Contributor

Added StructuredMeshView{2} to various flux functions to fix issue with some coupled simulations.

Copy link
Contributor

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md with its PR number.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

@SimonCan SimonCan requested a review from sloede June 18, 2024 15:56
sloede
sloede previously approved these changes Jun 18, 2024
@sloede
Copy link
Member

sloede commented Jun 18, 2024

LGTM. Please run formatter, mark as ready for review, and re-request review 😊

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.19%. Comparing base (58acd35) to head (cb775a0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1986   +/-   ##
=======================================
  Coverage   96.19%   96.19%           
=======================================
  Files         460      460           
  Lines       36993    36993           
=======================================
  Hits        35584    35584           
  Misses       1409     1409           
Flag Coverage Δ
unittests 96.19% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SimonCan
Copy link
Contributor Author

LGTM. Please run formatter, mark as ready for review, and re-request review 😊

Thanks. Just applied it.

@SimonCan SimonCan marked this pull request as ready for review June 21, 2024 11:29
@SimonCan SimonCan added the enhancement New feature or request label Jun 21, 2024
@SimonCan SimonCan requested a review from sloede July 2, 2024 16:42
@sloede sloede merged commit 4d91a86 into main Jul 3, 2024
38 checks passed
@sloede sloede deleted the sc/add_mesh_view_fluxes branch July 3, 2024 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants