-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CompatHelper: bump compat for Static to 1, (keep existing compat) #1992
base: main
Are you sure you want to change the base?
CompatHelper: bump compat for Static to 1, (keep existing compat) #1992
Conversation
dae5a8a
to
1b0a753
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's still using the old version in CI
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1992 +/- ##
=======================================
Coverage 96.37% 96.37%
=======================================
Files 480 480
Lines 38184 38184
=======================================
Hits 36798 36798
Misses 1386 1386
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
It's still using the old version in CI |
I came across this issue and noticed something I do not understand: I removed Trixi's compat entry for I then |
This is true because the PR (JuliaSIMD/StrideArrays.jl#90), which bumps the compat for Static is not included in any release of StrideArrays.jl (the latest release of StrideArrays.jl is more than one year old, but the PR is only 4 months old). StrideArrays.jl should register a new version. This also explains why |
Of course! I only looked at main. Thanks for the insight! |
Static.jl is still at v0.8: https://github.com/trixi-framework/Trixi.jl/actions/runs/11915911752/job/33207322754?pr=1992#step:8:326 |
This pull request changes the compat entry for the
Static
package from0.8.7
to0.8.7, 1
.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.