Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for Static to 1, (keep existing compat) #1992

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the Static package from 0.8.7 to 0.8.7, 1.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@github-actions github-actions bot force-pushed the compathelper/new_version/2024-06-27-00-04-49-975-03976288447 branch from dae5a8a to 1b0a753 Compare June 27, 2024 00:04
sloede
sloede previously approved these changes Jun 27, 2024
@sloede sloede closed this Jun 27, 2024
@sloede sloede reopened this Jun 27, 2024
Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still using the old version in CI

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.37%. Comparing base (db83c71) to head (0366260).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1992   +/-   ##
=======================================
  Coverage   96.37%   96.37%           
=======================================
  Files         480      480           
  Lines       38184    38184           
=======================================
  Hits        36798    36798           
  Misses       1386     1386           
Flag Coverage Δ
unittests 96.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@ranocha
Copy link
Member

ranocha commented Oct 10, 2024

It's still using the old version in CI

@benegee
Copy link
Contributor

benegee commented Oct 28, 2024

I came across this issue and noticed something I do not understand:

I removed Trixi's compat entry for Static and tried to update. Pkg then tells me that StrideArrays.jl would restrict Static's version to < 0.8.x, which is not true.
(https://github.com/JuliaSIMD/StrideArrays.jl/blob/0c057e9a9f06d16a1b90a7682008d3e97a2624d0/Project.toml#L29)

I then dev --localed StrideArrays.jl, updated, and everything worked.

@JoshuaLampert
Copy link
Member

JoshuaLampert commented Oct 28, 2024

Pkg then tells me that StrideArrays.jl would restrict Static's version to < 0.8.x, which is not true.

This is true because the PR (JuliaSIMD/StrideArrays.jl#90), which bumps the compat for Static is not included in any release of StrideArrays.jl (the latest release of StrideArrays.jl is more than one year old, but the PR is only 4 months old). StrideArrays.jl should register a new version. This also explains why deving StrideArrays.jl fixes this.

@benegee
Copy link
Contributor

benegee commented Oct 28, 2024

Of course! I only looked at main. Thanks for the insight!

@ranocha
Copy link
Member

ranocha commented Nov 19, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants