-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more zeros to solution file name #1996
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1996 +/- ##
=======================================
Coverage 96.16% 96.16%
=======================================
Files 460 460
Lines 36984 36984
=======================================
Hits 35564 35564
Misses 1420 1420
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This needs downstream changes in Trixi2Vtk.jl. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! I have updated the other output callbacks and the NEWS.md.
@sloede Could you please review this PR as well? If you're fine, we can release this in v0.8 and make the appropriate changes to Trixi2Vtk.jl as noticed by @JoshuaLampert |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (I assume you have grep'd for all occurrences of %06d
and replaced them by %09d
where appropriate; I didn't double-check this)!
This allows the number in the solution file name to max out at 999999999.