Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more zeros to solution file name #1996

Merged
merged 8 commits into from
Jul 2, 2024
Merged

Add more zeros to solution file name #1996

merged 8 commits into from
Jul 2, 2024

Conversation

andrewwinters5000
Copy link
Member

This allows the number in the solution file name to max out at 999999999.

Copy link
Contributor

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md with its PR number.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.16%. Comparing base (29eb55a) to head (9ca5803).

Files Patch % Lines
src/callbacks_step/save_solution_dg.jl 50.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1996   +/-   ##
=======================================
  Coverage   96.16%   96.16%           
=======================================
  Files         460      460           
  Lines       36984    36984           
=======================================
  Hits        35564    35564           
  Misses       1420     1420           
Flag Coverage Δ
unittests 96.16% <86.67%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoshuaLampert
Copy link
Member

JoshuaLampert commented Jun 28, 2024

This needs downstream changes in Trixi2Vtk.jl.

ranocha
ranocha previously approved these changes Jul 1, 2024
Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! I have updated the other output callbacks and the NEWS.md.

@ranocha
Copy link
Member

ranocha commented Jul 1, 2024

@sloede Could you please review this PR as well? If you're fine, we can release this in v0.8 and make the appropriate changes to Trixi2Vtk.jl as noticed by @JoshuaLampert

sloede
sloede previously approved these changes Jul 1, 2024
Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (I assume you have grep'd for all occurrences of %06d and replaced them by %09d where appropriate; I didn't double-check this)!

@ranocha ranocha dismissed stale reviews from sloede and themself via bea873a July 1, 2024 13:48
@ranocha ranocha mentioned this pull request Jul 1, 2024
2 tasks
@ranocha ranocha linked an issue Jul 1, 2024 that may be closed by this pull request
2 tasks
@ranocha ranocha merged commit 59bb592 into main Jul 2, 2024
32 of 33 checks passed
@ranocha ranocha deleted the adjust-filname branch July 2, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release v0.8
4 participants