Stabilize simulations to avoid differences between CI and local runs

.github/workflows/ci.yml

@@ -60,27 +60,65 @@ jobs:
         arch:
           - x64
         trixi_test:
-          - tree_part1
           - tree_part2
           - tree_part3
-          - tree_part4
-          - tree_part5
-          - tree_part6
           - structured
           - p4est_part1
           - p4est_part2
           - t8code_part1
           - t8code_part2
           - unstructured_dgmulti
-          - parabolic
-          - paper_self_gravitating_gas_dynamics
           - misc_part1
           - misc_part2
           - performance_specializations_part1
           - performance_specializations_part2
           - mpi
           - threaded
         include:
+          - version: '1.10'
+            os: macos-latest
+            arch: x64
+            trixi_test: tree_part2
+          - version: '1.10'
+            os: macos-latest
+            arch: x64
+            trixi_test: tree_part3
+          - version: '1.10'
+            os: macos-latest
+            arch: x64
+            trixi_test: structured
+          - version: '1.10'
+            os: macos-latest
+            arch: aarch64
+            trixi_test: tree_part2
+          - version: '1.10'
+            os: macos-latest
+            arch: aarch64
+            trixi_test: structured
+          - version: '1.10'
+            os: windows-latest
+            arch: x64
+            trixi_test: tree_part2
+          - version: '1.10'
+            os: windows-latest
+            arch: x64
+            trixi_test: tree_part3
+          - version: '1.10'
+            os: windows-latest
+            arch: x64
+            trixi_test: structured
+          - version: '~1.11.0-0'
+            os: ubuntu-latest
+            arch: x64
+            trixi_test: tree_part2
+          - version: '~1.11.0-0'
+            os: ubuntu-latest
+            arch: x64
+            trixi_test: tree_part3
+          - version: '~1.11.0-0'
+            os: ubuntu-latest
+            arch: x64
+            trixi_test: structured
           - version: '1.8'
             os: ubuntu-latest
             arch: x64

examples/structured_2d_dgsem/elixir_euler_sedov_blast_wave_sc_subcell.jl

@@ -51,7 +51,9 @@ limiter_idp = SubcellLimiterIDP(equations, basis;
                                 local_twosided_variables_cons = ["rho"],
                                 local_onesided_variables_nonlinear = [(Trixi.entropy_guermond_etal,
                                                                        min)],
-                                max_iterations_newton = 40, # Default value of 10 iterations is too low to fulfill bounds.
+                                # Setup with default parameters doesn't fulfill local bounds.
+                                max_iterations_newton = 40,
+                                newton_tolerances = (1.0e-13, 1.0e-15),
                                 positivity_variables_cons = [],
                                 positivity_variables_nonlinear = [])
 # Variables for global limiting (`positivity_variables_cons` and
@@ -96,7 +98,7 @@ save_solution = SaveSolutionCallback(interval = 100,
                                      save_final_solution = true,
                                      solution_variables = cons2prim)
 
-stepsize_callback = StepsizeCallback(cfl = 0.7)
+stepsize_callback = StepsizeCallback(cfl = 0.6)
 
 callbacks = CallbackSet(summary_callback,
                         analysis_callback, alive_callback,

examples/tree_2d_dgsem/elixir_euler_blast_wave_sc_subcell_nonperiodic.jl

@@ -43,7 +43,9 @@ basis = LobattoLegendreBasis(3)
 limiter_idp = SubcellLimiterIDP(equations, basis;
                                 local_twosided_variables_cons = ["rho"],
                                 local_onesided_variables_nonlinear = [(Trixi.entropy_math,
-                                                                       max)])
+                                                                       max)],
+                                max_iterations_newton = 70,
+                                newton_tolerances = (1.0e-13, 1.0e-14))
 volume_integral = VolumeIntegralSubcellLimiting(limiter_idp;
                                                 volume_flux_dg = volume_flux,
                                                 volume_flux_fv = surface_flux)

examples/tree_2d_dgsem/elixir_euler_sedov_blast_wave_sc_subcell.jl

@@ -44,7 +44,10 @@ basis = LobattoLegendreBasis(3)
 limiter_idp = SubcellLimiterIDP(equations, basis;
                                 local_twosided_variables_cons = ["rho"],
                                 local_onesided_variables_nonlinear = [(Trixi.entropy_guermond_etal,
-                                                                       min)])
+                                                                       min)],
+                                positivity_variables_nonlinear = [pressure],
+                                max_iterations_newton = 60,
+                                newton_tolerances = (1.0e-13, 1.0e-15))
 volume_integral = VolumeIntegralSubcellLimiting(limiter_idp;
                                                 volume_flux_dg = volume_flux,
                                                 volume_flux_fv = surface_flux)
@@ -53,7 +56,7 @@ solver = DGSEM(basis, surface_flux, volume_integral)
 coordinates_min = (-2.0, -2.0)
 coordinates_max = (2.0, 2.0)
 mesh = TreeMesh(coordinates_min, coordinates_max,
-                initial_refinement_level = 3,
+                initial_refinement_level = 5,
                 n_cells_max = 100_000)
 
 semi = SemidiscretizationHyperbolic(mesh, equations, initial_condition, solver)
@@ -76,7 +79,7 @@ save_solution = SaveSolutionCallback(interval = 1000,
                                      save_final_solution = true,
                                      solution_variables = cons2prim)
 
-stepsize_callback = StepsizeCallback(cfl = 0.6)
+stepsize_callback = StepsizeCallback(cfl = 0.4)
 
 callbacks = CallbackSet(summary_callback,
                         analysis_callback, alive_callback,

examples/tree_2d_dgsem/elixir_eulermulti_shock_bubble_shockcapturing_subcell_minmax.jl

@@ -121,7 +121,7 @@ save_solution = SaveSolutionCallback(interval = 600,
                                      save_final_solution = true,
                                      solution_variables = cons2prim)
 
-stepsize_callback = StepsizeCallback(cfl = 0.5)
+stepsize_callback = StepsizeCallback(cfl = 0.4)
 
 callbacks = CallbackSet(summary_callback,
                         analysis_callback,

src/solvers/dgsem_tree/subcell_limiters_2d.jl

@@ -323,9 +323,6 @@ end
             Pm = min(0, val_flux1_local) + min(0, val_flux1_local_ip1) +
                  min(0, val_flux2_local) + min(0, val_flux2_local_jp1)
 
-            Qp = max(0, (var_max[i, j, element] - var) / dt)
-            Qm = min(0, (var_min[i, j, element] - var) / dt)
-
             Pp = inverse_jacobian * Pp
             Pm = inverse_jacobian * Pm
 

test/runtests.jl

@@ -72,9 +72,9 @@ const TRIXI_NTHREADS = clamp(Sys.CPU_THREADS, 2, 3)
     end
 
     @time if TRIXI_TEST == "all" || TRIXI_TEST == "structured"
-        include("test_structured_1d.jl")
+        # include("test_structured_1d.jl")
         include("test_structured_2d.jl")
-        include("test_structured_3d.jl")
+        # include("test_structured_3d.jl")
     end
 
     @time if TRIXI_TEST == "all" || TRIXI_TEST == "p4est_part1"