Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Sc/p4est view coupled #2047

Closed
wants to merge 70 commits into from
Closed

WIP: Sc/p4est view coupled #2047

wants to merge 70 commits into from

Conversation

SimonCan
Copy link
Contributor

First step towards full p4est mesh coupling.

SimonCan and others added 30 commits June 26, 2023 16:31
@SimonCan
Added coupling converters.
bb07419
@SimonCan
Added generic converter_function for structured 2d meshes.
95892bf
@SimonCan
Merge branch 'main' of github.com:trixi-framework/Trixi.jl
e4f3a2b
@SimonCan
Merge branch 'main' of github.com:trixi-framework/Trixi.jl
b2ffe2c
@SimonCan
Merge branch 'main' of github.com:trixi-framework/Trixi.jl
53e38ad
@SimonCan
Merge branch 'main' of github.com:trixi-framework/Trixi.jl
36380cd
@SimonCan
Merge branch 'main' of github.com:trixi-framework/Trixi.jl
b754ea2
@SimonCan
Merge branch 'main' of github.com:trixi-framework/Trixi.jl
d3453db
@SimonCan
Merge branch 'main' of github.com:trixi-framework/Trixi.jl
e56b65e
@SimonCan
Merge branch 'main' of github.com:trixi-framework/Trixi.jl
0470314
@SimonCan
Merge branch 'main' of github.com:trixi-framework/Trixi.jl
21b72f6
@SimonCan
Merge branch 'main' of github.com:trixi-framework/Trixi.jl
1859121
@SimonCan
Merge branch 'main' of github.com:trixi-framework/Trixi.jl
7ec655b
@SimonCan
Merge branch 'main' of github.com:trixi-framework/Trixi.jl
185b4fc
@SimonCan
Added p4est-view.
6fdc714
@SimonCan
Added p4estMeshView to various routines.
1a38c0c 
More to come, especially bug fixing.
@SimonCan
Merge branch 'main' into sc/p4est-view
ab26c8c
@SimonCan
Added P4estMeshView in further functions.
65a00ba
@SimonCan
Merge branch 'sc/p4est-view' of github.com:trixi-framework/Trixi.jl i…
f1fe6b9 
…nto sc/p4est-view
@SimonCan
Removed redundant toml files.
a192873 
Merge branch 'main' into sc/p4est-view
@SimonCan
Removed redundant toml files.
40c4e0a
@SimonCan
Removed redundant files.
8f5216e
@SimonCan
Removed elixir on p4est coupling.
675e514 
This should be part of a coupling branch.
@SimonCan
Removed default coupling converter functions.
e130946
@SimonCan
Fixed some merge errors.
6b9783b
@SimonCan
Fixed merging issues.
b8b2573
@SimonCan
Removed redundant p4est-view code.
bedfd55 
Added a few comments, mostly todos.
@SimonCan
Merge branch 'main' into sc/p4est-view
6503b7f
@SimonCan
Added P4estMeshView.
7b7900f 
Runs without syntax errors.
No save_solution yet.
@SimonCan
Added P4estMeshView to a few more function as union with P4estMesh.
11190d6 
This version now runs.
SimonCan and others added 22 commits July 17, 2024 18:16
@SimonCan
Merge branch 'main' into sc/p4est-view
bd9c156
@SimonCan
Changed mesh anem so that trixi2vtk can read it.
b8b992f
@SimonCan
Merge branch 'main' into sc/p4est-view
252ba9d
@SimonCan
Removed redundant isperiodic checking function.
09c8ee2
@SimonCan
Removed double occurence of function balance!(mesh::P4estMeshView{2}).
a43e82d
@SimonCan
Added optin for p4est write out in coupled simulations.
e087369
@SimonCan
Added system to the mesh file neames for p4est mesh views.
455d53e
@SimonCan
Applied autoformatter.
f058b57
@SimonCan
Added indexed size function for p4est mesh views.
1cdfd88
@SimonCan
Changed the p4est mesh view example to two mesh views
4ee4a73 
that sit side by side without coupling.
@SimonCan
Merge branch 'main' into sc/p4est-view
e5644bf
@SimonCan
Applied autoformatter.
7ab4485
@SimonCan
Merge branch 'sc/p4est-view' of https://github.com/trixi-framework/Tr…
593a213 
…ixi.jl into sc/p4est-view
@SimonCan
Added structures to the coupled semidiscretiation that will be used
d15872d 
for a proper p4est mesh coupling.
@SimonCan
Corrected trees_per_dimension in p4est mesh views.
7cca87a
@SimonCan
Updated errors in p4est view test.
c57364d
@SimonCan
Merge branch 'sc/p4est-view' into sc/p4est-view-coupled
b80d14f
@SimonCan
Added trees_per_dimension to p4est mesh views so we can determine
028db2e 
the size of the meshes.
@SimonCan
Corrections in boundary flux.
711d162
@SimonCan
Added debugging output.
bf612da
@SimonCan
Added P4estMeshView to Union.
9ea5422
@SimonCan
Adde P4estMeshView to flux_differencing_kernel! functions.
1b9be92
@github-actions GitHub Actions
Copy link
Contributor

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md with its PR number.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

@SimonCan SimonCan closed this Jan 22, 2025
@SimonCan SimonCan deleted the sc/p4est-view-coupled branch January 22, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@SimonCan