-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add function to calculate optimal CFL number for PERK2 integrator and related updates #2077
Add function to calculate optimal CFL number for PERK2 integrator and related updates #2077
Conversation
…lter the existing example
…alculated from dt_opt +fmt
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2077 +/- ##
==========================================
+ Coverage 96.32% 96.34% +0.02%
==========================================
Files 470 470
Lines 37485 37494 +9
==========================================
+ Hits 36106 36121 +15
+ Misses 1379 1373 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
src/time_integration/paired_explicit_runge_kutta/methods_PERK2.jl
Outdated
Show resolved
Hide resolved
Co-authored-by: Daniel Doehring <[email protected]>
Co-authored-by: Daniel Doehring <[email protected]>
…arisa-r/Trixi.jl into updated_cfl_number_calculation
PairedExplicitRK2(num_stages, base_path_monomial_coeffs::AbstractString, | ||
PairedExplicitRK2(num_stages, base_path_monomial_coeffs::AbstractString, dt_opt, | ||
bS = 1.0, cS = 0.5) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changed the interface here since it requires an additional argument, so it is a breaking change. Is this stuff declared as experimental so that we can just do it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I somehow forgot that I added the breaking label. We should revert this and merge with 0.9. #1997
Would you like me to open this PR again? |
Yes, sorry for this hazzle! My bad. |
This PR introduces a new function to compute the optimal CFL number based on the optimal time step for the PairedExplicitRK2 (PERK2) integrator.
TODO:
Please let me know if there are any suggestions or improvements!